Bug#662035: RFS: vorbisgain/0.37-1 [ITA] -- add Replay Gain volume tags to Ogg Vorbis files

[Benoît Knecht <benoit.knecht@fsfe.org>]

Hi Daniel,

Daniel Martí wrote:
> I am looking for a sponsor for my package "vorbisgain"
> 
>  * Package name    : vorbisgain
>    Version         : 0.37-1
>  * URL             : http://sjeng.org/vorbisgain.html
>  * License         : GPL-2
>    Section         : sound
> 
> It builds those binary packages:
> 
>   vorbisgain - add Replay Gain volume tags to Ogg Vorbis files

I had a look at your package and noted the following issues:

  - Your debian/copyright is inaccurate. The FSF and Michael Smith are
    not mentioned anywhere, although they own the copyright on some
    files. Most files seem to be LGPL, not GPL. You may need to clarify
    a few things with upstream, if possible; vorbis.c is said to be
    "distributed under the GNU General Public License, version 2.1" and
    that  "a copy of this license is included with this source", but the
    GPL-2.1 doesn't exist as far as I know, and the only license
    included in the source is the LGPL-2.1.

    You can use 'licensecheck -r --copyright .' to help you get the
    correct copyright information.

    You should also add yourself to the debian/* paragraph, and from the
    changelog, looks like Alessio Treglia should be there too.

    Upstream-Source isn't a valid field. Use Source.

    It is also customary to include a bit more of the license text in
    the License paragraphs. You can find what's usually included at the
    end of COPYING, from "This library is free software", and changing
    the last paragraph with "If not, see
    <http://www.gnu.org/licenses/>". You can then add one last paragraph
    that reads "On Debian systems, the complete text"...

  - In debian/rules, you now bypass 'make distclean' entirely. You
    probably want to call dh_auto_clean first in the override.

  - The upstream NEWS file should be installed as a changelog, not as
    documentation. See dh_installchangelogs(1). This will also get rid
    of a pedantic lintian warning.

  - In debian/changelog, you mentioned that you bumped the standards
    version; were any changes required for that? Note it in the
    changelog.

  - In the examples about recursion in vorbisgain(1), it would be much
    clearer if directory names included the suffix '/'.

Cheers,

-- 
Benoît Knecht