[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#658235: RFS: libjreen, the xmpp library (3rd try, 2 months later)

Vsevolod Velichko wrote:
> I'm very thankful for your package review. I've just fixed most of the
> things you mentioned. However, there're a couple of moments I'm
> unsure.
> >      I: libjreen1: no-symbols-control-file usr/lib/libjreen.so.1.0.1
> There was a long "C++ vs symbols" discussion[1] recently with pros and
> contras. I suppose, that symbols really doesn't make sense for C++ and
> too hard to maintain (just to create the appropriate symbols file, I
> have to somehow upload the package with initial .symbols version, wait
> for build fails everywhere, collect buildd logs, and only there I'll
> be able to create real .symbols file). For example, dpkg-gensymbols
> generates 1633 lines of .symbols for this library.
> Are you sure that it's really needed?

I was merely reporting the lintian output, in case you hadn't seen it
(people often run it without any additional flags and miss some relevant
warnings); but the severity of this particular tag is 'wishlist', so you
can ignore it if it doesn't make sense in your case.

> >    The dh_auto_install override could also be replaced by using
> >    debian/<package>.install files (see dh_install(1) for details).
> I'm unsure that .install is better solution. The one of mine should
> work in most cases, even if one change library and package names, I'll
> have to change only a package name in dh_auto_install override. In the
> case of .install files there would be more work. Am I right?

Well it just seems awfully convoluted for just moving two files; with
wildcards, you could achieve the same thing with just one line in
libjreen1.install (I'm not sure why you worry about library or package
name changes, that shouldn't happen too often, right?) But of course
your solution is not wrong, and it's ultimately your decision what to
do; I just find it more complex than necessary.

> I've uploaded new version to mentors[2], if you agree with my comments
> above, could you review and probably sponsor the fixed version,
> please?

Hmm, I thought it was clear from my email address, but I guess it's not;
I'm not a DD, so I can't sponsor your package. I'm just trying to help
out however I can, by reviewing other people's packages.

> [1] http://lists.debian.org/debian-devel/2012/01/thrd2.html#00671
> [2] http://mentors.debian.net/debian/pool/main/libj/libjreen/libjreen_1.0.1-1.dsc


Benoît Knecht

Reply to: