[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#659822: RFS: mpd-sima/0.9.0-1 (New upstream version)

Le 17/02/2012 01:28, Jakub Wilk a écrit :
> * Geoffroy Youri Berret <efrim@azylum.org>, 2012-02-17, 00:41:
>>> - In debian/mpd-sima.postrm, you use awk but you don't Depend on it.
>> Right, I replaced it with a “grep | cut” alternative.
> While I personally don't like awk :P, but if you like it, you _can_ use it in
> maintainer scripts without depending on it. awk is (in a way) an essential
> package:
> http://lists.debian.org/debian-mentors/2005/11/msg00193.html
> […]

Thanks for this Jakub, actually I did check if awk was essential, I felt it
might be essential by dependency, “virtually essential”, but I failed to
confirm it.

Do you see any problems with my "grep | cut" alternative?

>>> You're also checking if /usr/sbin/deluser is executable and silently not
>>> removing the user if it's not (same thing for delgroup). Since you Depend
>>> on adduser, you should assume these commands exist, and it should be an
>>> error visible to the user if they don't.
>> Corrected as well.
> Err. What Policy §6.5 says: “[…] all ‘postrm’ actions may only rely on
> essential packages and must gracefully skip any actions that require the
> package's dependencies if those dependencies are unavailable.”
> So checking for existence of /usr/sbin/deluser _is_ the right thing if you
> want to use it.
I reverted the postrm modifications.

> See this however:
> http://lists.debian.org/debian-devel/2012/02/msg00094.html
Is there a consensus then, even something official about how to deal system
users when purging a package. From the thread you mentioned I guess we should
not try to removed them.

> I recommend to write such wrappers in Python, so that a user can run the
> software using non-default version easily. Or even easier, just make
> /usr/bin/$something -> /usr/share/mpd-sima/$something symlinks.
I switched to symlinks which looks better IMHO, at least I believe it's always
better to keep things simple when possible.

I've uploaded a new version of the package which I believe is in a pretty good
shape now.

Could somebody review, tag the bts report or upload it if everything is fine?

dget -x http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.9.0-1.dsc


Reply to: