[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: pygame



On Tue, Sep 20, 2011 at 11:44 AM, Ansgar Burchardt <ansgar@debian.org> wrote:
> Hi,
>
> Vincent Cheng <vincentc1208@gmail.com> writes:
>>   dget -x http://mentors.debian.net/debian/pool/main/p/pygame/pygame_1.9.1release-2.dsc
>
> Your changes look okay, but could you please document the copyright
> holder and license for freesansbold.ttf[1]?  You might also want to
> change "Debian GNU/Linux systems" to just "Debian systems" in
> d/copyright (yes, nitpicking ;) ).

Done. Also migrated debian/copyright to DEP-5.

> Why do you use version mangling to remove "release" from the Debian
> version in debian/watch?  You could just include it in the regexp
> matching the upstream version.

Fixed.

> The VCS also does not seem to contain the current package.

Forgot to upload my changes, thanks for reminding me!

I've re-uploaded my package to debian-mentors and it's ready for
another round of reviews:

$ dget -x http://mentors.debian.net/debian/pool/main/p/pygame/pygame_1.9.1release-2.dsc

Vincent


Reply to: