[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: django-autoslug



* Jocelyn Delalande <debian@hackriculture.fr>, 2011-09-06, 01:46:
First of all, as it's my initial post here ; so I just wanted to say Hi to you all, I hope we'll happy-hack together :-). I'll mainly work with Python packaging, as it's a language I know well, love fairly. I use some nice pieces of python software missing just the deb packaging to hit the full awesomeness rank, sounds like a mission for me :-)

For future, debian-python@lists.debian.org might a better place to ask for sponsorship of packages like this.

To access further information about this package, please visit the following URL:

http://mentors.debian.net/package/django-autoslug

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/d/django-autoslug/django-autoslug_1.4.1-1.dsc

I would be glad if someone uploaded this package for me.


I tried to stick to naming used with other django apps in debian.

According to Python Policy 2.2, the binary package name should be python-autoslug. (Now, you may say that's too generic and that the package name should include "django" - but so should upstream module name...)

debian/control:
- Remove XB-Python-Version, it servers no purpose.
- More importantly, remove "Provides: ${python:Provides}". See <http://lists.debian.org/debian-python/2011/03/msg00139.html> for rationale. - Short description is not a sentence, so it should not end with a dot. See Developer's Reference 6.2.2.

debian/python-django-autoslug.preinst:
- It doesn't make sense. You package was never affected by #479852 (besides, the bug is already fixed in stable).

debian/rules:
- Please consider removing useless comments.
- Unexporting anything is not necessary, the *FLAGS don't affect your package by any means.

debian/watch:
- Please write one. That shouldn't be hard, as the tarballs are available at PyPI.

autoslug/__version.py:
- So is it 1.3.5 or 1.4.1 after all?

autoslug/tests.py:
- Please run them at build time.


You might want consider joining the Python Modules Packaging Team: http://wiki.debian.org/Teams/PythonModulesTeam/HowToJoin

--
Jakub Wilk


Reply to: