Re: RFS: dfu-programmer
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Rodolphe,
On 18.08.2011 14:11, Rodolphe Pelloux-Prayer wrote:
> So the new upload is not a NMU anymore and it could be my first official package :)
Here are a few comments about your package:
* Please consider using a more recent debhelper compatibility level.
Version 5 is quite outdated (although still okish). Generally I suggest
to bump debian/compat to 8 and depend in debian/control on a 8.0
version. That works down to Lenny with backports, although your package
probably won't ever enter Stable or even Oldstable anyway.
* You use a VCS not hosted by Debian. That's ok and legit, but Alioth is
nice too, and eases life to other people, potentially interested to help
you with the package. Regardless of the repository you choose, the
VCS-Browser link should point to the trunk of your repository, not to
the project home page [1]
* If I understand the purpose of your program, the section devel is not
really appropriate - maybe "electronics" [2] fits better.
* Upstream's NEWS file you install as doc, is in fact a changelog. For
archive-wide consistency you might consider installing it as upstream
changelog through dh_installchangelogs(1). Figure, that would also make
Lintian pedantically happy!
* Please remove unneeded comments in debian/rules. Those are for your
information, and not intended to be kept.
Good work, your package looks good. As you might have noticed, my
comments are minor pedantic notes.
[1]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-vcs
[2] http://packages.debian.org/unstable/electronics/
- --
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJOTQqUAAoJEMcrUe6dgPNtFcYP/i6fgDAh4cWtoC590bIR5lt9
RRmOF4/rfhy/f1lgOPUFm4UuUrlojus4uFHagVcKu9NxAQ7KGijwDXHO7hnc2iIE
kvvwhjAXpiVFTRgnxX9Y5LHWUrl2geLAXva8VwyZO30Gg4ngGefwbSVT/dVb3kXq
n5KU3DROh7h4xzIjzlaUxuOif8ha5AXKZO21qRw117ZPXZhiNCHIq5Cmxe3bpj8y
AtLaVlgaKDIAdn8usDTGBlSWYC6Ub3vD+c3Iyku2XskkeWjwcUPkS5YoshsqBibe
c+tXUP0VrL0sghDBouvYCEKfEutF459GmPr4d7JZaLPnn5/Fz1PDn9jVgqXDOwD+
9quBXaD/3zAWVOI0yXvfCyIIrgedn+RaAovS/b75B4HDn5Kovh1a//lIv+6fAwCJ
Skln0BZu6DWd4rQ1A5I0BBToAbCcXCkLHZgck2DA6xAuzVW8kDyUaDL2K4anNa5k
sbK4oG4NiPDXkULta1WmVwrvQFg5adYOSZkNQ6aKQRBrrGr+yyIDIak5/i58+RXz
G+YnafD6oYYM3jaDv4AJU03k9ZGgUvXI7Zc1q1nvoVvuiYrtWzr4nnVCA3Bg+0Aw
MHWxNNr94xU38ED471O53/8kkYkdpjmkZ6FjqMw6aEMv7GsiNgYpkDDsZJ2i62a8
VrIMNx3i9M6L6j4HVAre
=Ur9O
-----END PGP SIGNATURE-----
Reply to: