[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ndpmon



Hi John,

On Sat, Aug 06, 2011 at 05:26:26PM -0400, John R. Baskwill wrote:
> 2011/8/4 Benoît Knecht <benoit.knecht@fsfe.org>
[...]
> > > >  - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:
> > > >
> > > >      W: ndpmon source: configure-generated-file-in-source config.status
> > > >      W: ndpmon source: configure-generated-file-in-source config.cache
> > > >      W: ndpmon source: configure-generated-file-in-source config.log
> >
> 
> These files are included in the original tarball.  I modified the clean
> target to remove these files, and also included lintian overrides for the
> files.  I will suggest to upstream to not include these files in the future.
>  I do have one question about the tarball, though.  The file I downloaded
> was named ndpmon-1.4.0.tgz.  Everything I read about packaging seemed to
> assume the tarball would be named ndpmon-1.4.0.tar.gz, so I renamed the
> file.  Is that permissible, or should I have left the name as it was?

Renaming is fine. uscan will do that for you even if you ask it to --rename.

As you have a configure-based upstream source I hope you've put
autotools-dev in charge of keeping your config.* files up to date. ;-)


> > > >      W: ndpmon source: out-of-date-standards-version 3.9.1 (current is
> > > > 3.9.2)
> >
> 
> My lintian says the current standard is 3.9.1, but OK.

Then use the latest unstable or backports version. ;-)


[...]
> > > >      I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved
> > Received
> > > >      I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
> > > >      I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > > >      I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > > >      I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o
> > Recieved
> > > > Received
> > > >      I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress
> > > > address
> > > >      I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o
> > unkown
> > > > unknown
> > > >      I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o
> > unkown
> > > > unknown
> > > >      E: ndpmon: helper-templates-in-copyright
> > > >      I: ndpmon: spelling-error-in-manpage
> > usr/share/man/man8/ndpmon.8.gz
> > > > allows to allows one to
> > > >
> >
> 
> I included patches to correct the spelling errors.  The patches have not
> been sent upstream yet, but I will do that.  The copyright file is in DEP5
> format.

Patches should have their headers in DEP-3 format. DEP-5 is for
debian/changelog only.

[...]

Thanks for keeping us posted!

Please also tell us when the next version is up on mentors.d.n for review.

-- 
Best regards,
Kilian

Attachment: signature.asc
Description: Digital signature


Reply to: