Re: RFS: ndpmon

2011/8/4 Benoît Knecht <benoit.knecht@fsfe.org>

Hi John,

John R. Baskwill wrote:
> I am looking for a sponsor for my package "ndpmon",
>
> * Package name : ndpmon
> Version : 1.4.0-2
> Upstream Author : frederic.beck@loria.fr
> * URL : http://ndpmon.sourceforge.net/index.html
> * License : LGPL 2.1+
> Section : net
>
> It builds these binary packages:
> ndpmon - IPv6 Neighbor Discovery Protocol Monitor
>
> The upload would fix these bugs: 635975

>From a quick look at your package:

- You have a debian/patches/debian-changes-1.4.0-1 patch that is
probably not intentional.

- It would be great if you could use DEP-5 [1] for your
debian/copyright.

[1] http://dep.debian.net/deps/dep5/

Also, if you run 'licensecheck -r .' in the root directory of your
package, you'll notice that some files lack a copyright header. You
should probably contact upstream about that and make sure that all
the files are indeed released under the LGPL.

- 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:

W: ndpmon source: configure-generated-file-in-source config.status
W: ndpmon source: configure-generated-file-in-source config.cache
W: ndpmon source: configure-generated-file-in-source config.log
W: ndpmon source: out-of-date-standards-version 3.9.1 (current is 3.9.2)
I: ndpmon source: debian-watch-contains-dh_make-template
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved Received
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o Recieved Received
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress address
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown unknown
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown unknown
E: ndpmon: helper-templates-in-copyright
I: ndpmon: spelling-error-in-manpage usr/share/man/man8/ndpmon.8.gz allows to allows one to

(Run it with '-i' to get a detailed explanation for each warning or
error.)

- Your .deb contains plenty of .{c,h,o} files, and the full source in
/usr/src; I don't think it's what you intended to do, is it?

- In debian/control, the description of the package contains
information about when, where and by whom the software was
developed; I don't think it's relevant here. You also depend
explicitly on some libraries, but these should be in
${shlibs:Depends} already if the package links against them.

I hope this helps. Don't hesitate to ask if you have problems/questions
about these issues.

Cheers,

--
Benoît Knecht

--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Archive: [🔎] 20110804151446.GA3933@marvin.lan" target="_blank">http://lists.debian.org/[🔎] 20110804151446.GA3933@marvin.lan