[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: trophy (Adopted and updated package)



Hi Andreas,

On Sun, 2011-07-03 at 20:09 +0200, Andreas Moog wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 1.1.7-1
> of my package "trophy".
> 
> It builds these binary packages:
> trophy     - 2D car racing action game
> trophy-data - 2D car racing action game (data files)
> trophy-dbg - 2D car racing action game (debugging symbols)
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 622168, 632562
> 
> The package can be found on mentors.debian.net:
> 
> > dget http://mentors.debian.net/debian/pool/main/t/trophy/trophy_1.1.7-1.dsc
> 
> I would be glad if someone uploaded this package for me.

Thanks for stepping up as new maintainer for this orphaned package.

Regarding your package:

1. Using dh-autoreconf is ugly. Please try to avoid it and backport the
full regenerated configure in your patch to make sure the source is
identical on all buildds. IMHO dh-autoreconf is a solution for a local
build that you maintain for yourself outside of Debian, but not for an
official pacakge.

2. Your debian/copyright does list a specific version of your upstream
source as Source. Please use the generic URL so that this is valid for
all future versions.

3. I don't think --prefix=/usr is required with dh_auto_configure. That
should come automagically.

As the package is not orphaned for long I'd welcome if you could fix the
above and put forth a new package before we put it into Debian.

Thanks!

-- 
Best regards,
Kilian

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: