Re: RFS: lebiniou, lebiniou-data

[Etienne Millon <etienne.millon@gmail.com>]

Hello,

A few extra remarks from a non-DD :

debian/control
--------------

  - The VCS-* fields should be relative to the debian packaging, not
    the upstream repository. From what I've seen, this source package
    has been generated from the upstream "debian/" subdirectory. This
    is misleading because you can't easily export a tarball and use it
    as a .orig file.

    As you are the upstream author, I suggest that you use a single
    source package to build these two binary packages (one .dsc, two
    .debs). That should ease maintenance, including the following
    point.

  - The dependency against lebiniou-data is not versioned. That means
    that lebiniou is meant to be usable with any version of
    lebiniou-data. In such a case I think you need to specify exactly
    one version. With a single source package, you could depend on
    lebinou-data (= ${source:Version}).

Hope that helps,
-- 
Etienne Millon