[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: python-mplayer

Le 18 Dec 2011 23:12, Jakub Wilk a écrit:
> (I don't intend to sponsor this package.)
> I'd recommend using the upstream name (mplayer.py) for the source
> package name.

The upstream author seems to change the name of the project nearly at
each release but, ok, I'll try to stick to it.

Actually it seems I can't commit a rename of the project directory in
the repository ? I get "Authorization failed".

> Unless there's a compelling reason not do so, I'd merge both
> changelog entries into one.


> What is the "debian/python-module-stampdir" directory for?

It seems to have been auto-generated by some tools and added by mistake
to the repository. Removed.

> Why "Priority: extra"?

Changed to optional.

> It should be "mplayer (>= 1.0~rc3)" rather than "mplayer (>= 1.0rc3)".


> Architecture should be "all", not "any".


> "${shlibs:Depends}" can be removed from Depends, it's unused.


> The module doesn't handle filenames with special characters correctly:
> | >>> mplayer.Player('eggs"ham.avi')
> | Traceback (most recent call last):
> |   File "<stdin>", line 1, in <module>
> |   File "/usr/lib/python2.7/dist-packages/mplayer/core.py", line 102, in __init__
> |     self.args = args
> |   File "/usr/lib/python2.7/dist-packages/mplayer/core.py", line 142, in args
> |     args = shlex.split(args)
> |   File "/usr/lib/python2.7/shlex.py", line 279, in split
> |     return list(lex)
> |   File "/usr/lib/python2.7/shlex.py", line 269, in next
> |     token = self.get_token()
> |   File "/usr/lib/python2.7/shlex.py", line 96, in get_token
> |     raw = self.read_token()
> |   File "/usr/lib/python2.7/shlex.py", line 172, in read_token
> |     raise ValueError, "No closing quotation"
> | ValueError: No closing quotation

It works well for me. What are your python and mplayer version ?

> It looks like upstream supports also Python 3.X. Please consider
> supporting it in Debian, too (in a separate binary package,
> python3-mplayer).

Ok, I'll have a look to that.

> The comment at the top of debian/rules doesn't make sense.


Thank you very much for your comments. I just committed the updates to
the repository.



Reply to: