Re: RFS: python-mplayer

[Jakub Wilk <jwilk@debian.org>]

(I don't intend to sponsor this package.)

* Olivier Schwander <olivier.schwander@ens-lyon.org>, 2011-12-18, 14:34:
>  http://mentors.debian.net/package/python-mplayer
>
> Alternatively, one can download the package with dget using this
> command:
>
>  dget -x
>  http://mentors.debian.net/debian/pool/main/p/python-mplayer/python-mplayer_0.7.0-1.dsc

I'd recommend using the upstream name (mplayer.py) for the source 
package name.

Unless there's a compelling reason not do so, I'd merge both changelog 
entries into one.

What is the "debian/python-module-stampdir" directory for?

Why "Priority: extra"?

It should be "mplayer (>= 1.0~rc3)" rather than "mplayer (>= 1.0rc3)".

Architecture should be "all", not "any".

"${shlibs:Depends}" can be removed from Depends, it's unused.

The module doesn't handle filenames with special characters correctly:
| >>> mplayer.Player('eggs"ham.avi')
| Traceback (most recent call last):
|   File "<stdin>", line 1, in <module>
|   File "/usr/lib/python2.7/dist-packages/mplayer/core.py", line 102, in __init__
|     self.args = args
|   File "/usr/lib/python2.7/dist-packages/mplayer/core.py", line 142, in args
|     args = shlex.split(args)
|   File "/usr/lib/python2.7/shlex.py", line 279, in split
|     return list(lex)
|   File "/usr/lib/python2.7/shlex.py", line 269, in next
|     token = self.get_token()
|   File "/usr/lib/python2.7/shlex.py", line 96, in get_token
|     raw = self.read_token()
|   File "/usr/lib/python2.7/shlex.py", line 172, in read_token
|     raise ValueError, "No closing quotation"
| ValueError: No closing quotation

It looks like upstream supports also Python 3.X. Please consider 
supporting it in Debian, too (in a separate binary package, 
python3-mplayer).

The comment at the top of debian/rules doesn't make sense.

--
Jakub Wilk