Re: RFR: wader, a ModemManager replacement

[Alex Chiang <achiang@canonical.com>]

Hello Jakub,

* Jakub Wilk <jwilk@debian.org>:
> * Alex Chiang <achiang@canonical.com>, 2011-11-14, 13:29:
> > http://mentors.debian.net/package/wader
> >
> >Alternatively, one can download the package with dget using this command:
> >
> > dget -x http://mentors.debian.net/debian/pool/main/w/wader/wader_0.5.8-1.dsc
> 
> (I don't intend to sposnor this package.)

Thank you for the review.

> First of all, it should be:
> 
>      if sys.platform.startswith('linux')

Will fix.

> If someone tries to build the package without setuptools
> installed[0], setup.py will download it from the web, and then
> run... This is of terrible idea from the security perspective.
> Please patch out the use of ez_setup from setup.py.

You're right; I didn't notice because I did have setuptools
installed. I will fix this.

> In debian/rules, I'd replace "dist-packages" with "*-packages" to
> ease backporting to Squeeze.

Ok, I can fix this too.

> In wader/contrib/modal.py looks like an embedded copy of (part of)
> python-epsilon. Please don't install it into the binary package, but
> depend on python-epsilon and use it instead.

Ok, good suggestion, thanks.

> Are Python modules provided by wader supposed to be used by other
> software? If no, then please move them into a private directory. If
> they are, the package name should be python-wader.

Another package I plan on packaging will use some of the modules,
so we will do the rename.

Out of curiosity, where would the private directory live?

Thanks again!
/ac