[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ranger_1.5.2-1 (new upstream release)



I don't intend to sponsor this package, but here is a short review:

Your package has an RC bug that needs to be fixed:

http://bugs.debian.org/643782
https://bugs.launchpad.net/ubuntu/+source/ranger/+bug/879149

Your package has some changes that are not documented in debian/changelog.

Your lintian overrides claim that a few scripts are configuration
files. In that case, why are they not in /etc?

There is one other bug that you might want to look at and fix or
forward upstream:

http://bugs.debian.org/619748

python-support is deprecated, please switch to dh_python2:

http://wiki.debian.org/Python/TransitionToDHPython2

The README file contains installation info, you might want to get
upstream to split that out into README.install.

Please add DEP-3 headers to your patch:

http://dep.debian.net/deps/dep3/

Why do you override dh_auto_test? None of the tests fail.

Please take a look at the debtags and screenshots and update them if needed:

http://debtags.alioth.debian.org/edit.html?pkg=ranger
http://screenshots.debian.net/package/ranger

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: