Re: RFS: shedskin

[Jakub Wilk <jwilk@debian.org>]

* Paul Boddie <paul@boddie.org.uk>, 2011-11-01, 17:07:
>  http://mentors.debian.net/package/shedskin
>
> Alternatively, one can download the package with dget using this command:
>
>  dget -x \
>    http://mentors.debian.net/debian/pool/main/s/shedskin/shedskin_0.9-1.dsc

I don't intend to sponsor this package, but here's my review:

The patches look like if "Index: ..." was a part of patch header. I 
think this is not what you meant.[0]

You can't use regular expressions in Files fields of a DEP-5 copyright 
file.

I'd replace "Copyright: Copyright" with simply "Copyright:".

I don't think that "Any feedback is very welcome" is an appropriate 
thing to put into copyright file.

You probably want to add a paragraph about files in debian/ directory to 
the copyright file.

Is there any reason you list 8 different wildcards in debian/*.install, 
when what you really do is to install all files from a directory? You 
could have put just the directory name there...

Some aesthetical nitpicking: in debian/control, I'd put a space between 
">=" and "7.0.50~", and after "Homepage:".

I'd nice if you could move FLAGS* to a directory that's not in sys.path.

Are the Python modules that are currently public supposed to be used by 
other software? If not, I guess it'd make sense to move them into a 
private directory, too.

Will the .py files in /usr/share/shedskin/lib be ever used by a "normal" 
Python interpreter?

shedskin/inter.py has:

import gc, random
random.seed(42)

Is that intentional?


[0] I use these options to make my patches less noisy:
QUILT_DIFF_ARGS='-p ab'
QUILT_REFRESH_ARGS='-p ab'
QUILT_NO_DIFF_INDEX=1
QUILT_NO_DIFF_TIMESTAMPS=1

--
Jakub Wilk