[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ndppd

IANADD, so I cannot upload.

On Sun, Sep 18, 2011 at 08:42:40PM +0200, daniel.adolfsson@tuhox.com wrote:
> I am looking for a sponsor for my package "ndppd".

Please mention in your RFS subject whether the package is new. In this
case the package is new. As such, it should close an ITP bug. Please

>    Section         : unknown

"Section: unknown" doesn't seem like a good choice. What about net maybe?

> It builds those binary packages:
> ndppd - NDP Proxy Daemon

The package description is intended for users that do *not* yet know
what your software is about. As such your short description should
explain that it is related to IPv6 and your long description should also
cover more than two lines.

> Details:
> It's basically a daemon that proxies IPv6 Neighbor Discovery
> messages between
> two (or more) interfaces - to allow "routing" of smaller subnets
> than /64.
> The host machine listens for Neighbor Solicitation messages on one
> interface,
> and then query another interface to see if that IP is used. If it
> is, the host
> will then answer with a Neighbor Advertisement message. More details
> about the
> daemon can be found at the provided URL above.

This seems more appropriate as a long description.

>   dget -x http://mentors.debian.net/debian/pool/main/n/ndppd/ndppd_0.2.1~rc1-1.dsc

The Vcs-* fields in debian/control are supposed to contain locations of
the Debian packaging, not the upstream source. I suggest that you remove
them and put those urls in the documentation. The copyright file might
be a good place.

On the copyright file: I encourage you to have a look at the
http://dep.debian.net/deps/dep5/ copyright format. On the other hand
using this format is *not* required. (Some sponsors seem to require it.)

Why do you restrict the architectures of the binary package to i386 and
amd64? Please explain or fix.

Your Standards-Version is out of date. Please always develop on Debian

You mentioned a homepage in your email. Maybe you can add a Homepage
header in the source section of your debian/control?

Your debian/init.d contains unreferenced cruft such as do_reload. Maybe
you can clean it up a bit?

While we're at cleaning. Here's a quote from your debian/rules:
"# Sample debian/rules that uses debhelper." Maybe you could shrink that
one as well?

As you seem to be upstream as well I ask you to polish your upstream
Makefile as well. For instance honouring the $PREFIX environment
variable helps bsd systems with using your software. I'd envision
something like this:

PREFIX ?= /usr/local
MANDIR ?= ${PREFIX}/share/man
	mkdir -p ${DESTDIR}${SBINDIR} ${DESTDIR}${MANDIR}/man1 ${DESTDIR}${MANDIR}/man5

This employs a number of differences to your old method. The $*DIR
variables now contain the final location of files. So if you ever need
those locations to update configuration before installing, you can then
use them. The use of $PREFIX allows installation to the traditional
/usr/local location. Furthermore setting those variables with ?= allows
overriding them. The same applies to to CFLAGS and CC (which should be
called CXXFLAGS and CXX) as well.

I think that (once these problems are sorted out) the software would be
a good addition to the Debian software repository extending the growing
IPv6 field.


Reply to: