[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mpd-sima (updated package)



Hi Geoff,

On Mon, Aug 01, 2011 at 04:42:15PM +0200, Geoffroy Youri Berret wrote:
> I gentle ping on this package :)
> 
> I moved the packaged to "Debian Multimedia Maintainers".
> 	git://git.debian.org/pkg-multimedia/mpd-sima.git
> 
> I believe the package to be in pretty good shape now.

Thanks for your work. From a first look:

1.) You build-depend on bash-completion. What for? Moreover you build-depend
    on python-all which huge compared to what you will actually need IMHO.
    Why not limit that more to what is actually required?

2.) You should leave the new upload at 0.8.0-1 because your changelog entry
    never made it into unstable as a package. (Your sponsor would need to
    build with -sa and -v etc. etc. which is nasty)

3.) You drop debian/html from the docs without mentioning in the changelog

5.) http://sima.codingteam.net seems no longer valid. New homepage is at...?

6.) /usr/share/common-licenses/GPL in debian/copyright should rather be the
    versioned reference (GPL-3)

7.) lintian proposes to enhance simadb_cli.1.gz: "allows to" should be "allows one to"


> I would be glad if someone uploaded this package for me.

Please comment the above and I'll put it in.

-- 
Best regards,
Kilian

Attachment: signature.asc
Description: Digital signature


Reply to: