Hi Daniel, On Mon, Aug 01, 2011 at 05:36:36PM +0200, Daniel Lombraña González wrote: > 2011/7/30 Michael Tautschnig <mt@debian.org> > > > I have update the package with the latest available version 1.3. Please, > > can > > > you check if everything is OK? > > > > > [...] > > > > I just thought I'd briefly check whether your orig.tar.gz matches the > > upstream > > tar.gz, found different md5sums and then this: > > > > (omitting full diffstat output) > > 78 files changed, 3771 insertions(+), 4496 deletions(-) > > > > !? > > > > It seems you completely reorganized the source tree. That's not quite the > > point > > of a .orig.tar.gz file. > > > > I'm sorry, I thought I have to reorganized the source tree to create the > package. Now I have understood the problem, and a new version has been > uploaded. This one has the original tar.gz. I hope this time, at least this > issue is fixed. Thanks for the update. Your debian/watch however still doesn't work for me. A version that would work looks at least like this: version=3 opts="downloadurlmangle=s#\/\/code.google.com##" \ http://code.google.com/p/libchart/downloads/list \ //libchart.googlecode.com/files/libchart-(.*)\.tar\.gz -(snip)- Feel free to provide an even better one if you can. =) Apart from that you still ship the *.ttf files inside your orig.tar.gz source. You will want to modify this as DFSG-repack (removing the ttf files entirely from the tarball) and leave your patch in place which looks ok from a first glimpse. A get-orig-source target inside debian/rules is the correct place to put this. Your standards-version is still at 3.9.1 and should be bumped to latest 3.9.2 - shouldn't be much of a problem. The debian/copyright looks a bit weird with the URL you point to. Please use DEP-5 (which is the to-be-standard) with its correct URL instead - and put a full verbatim GPL-3 quote. The URL http://libchart.googlecode.com/svn/trunk doesn't work. Neither does http://naku.dohcrew.com/libchart/pages/introduction. At least with a regular browser. Should they? I guess at least the latter should. The upstream changelog at libchart/ChangeLog should be shipped also in the package. Ping me or Michael when the above is done as that should make the package good enough for an initial upload. Thanks! -- Best regards, Kilian
Attachment:
signature.asc
Description: Digital signature