[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: l2tp-ipsec-vpn



Hi Werner,

[...]

I've taken another look at your package. For reference, I've used

http://mentors.debian.net/debian/pool/main/l/l2tp-ipsec-vpn/l2tp-ipsec-vpn_1.0.0-1.dsc

dated 29-Jul-2011 09:46.

The first thing I stumbled upon was the orig.tar.gz that doesn't match the
upstream one. Not only do md5sums differ, but the actual contents does:

(... diffstat output)
125 files changed, 116 insertions(+), 404 deletions(-)

Although these changes only concern revision control ids, it is IMHO not
acceptable to have orig.tar.gz differ in such a way from upstream's tar.gz.

Further comments:

- The description is clearly improved and the first stanza is appropriate;
  others, however, should probably only go in some README file. Please see
  Debian Policy about this, Section 3.4, which provides a very nice guideline
  what should (not) be included.
  (http://www.debian.org/doc/debian-policy/ch-binary.html#s-descriptions)
- debian/postinst:
  * service rsyslog restart || true   -- no, there is no service command in
    general in Debian. And why restart a foreign service!?
  * Why use gksu when su should do the trick? I really wouldn't want
    to do system administration remotely with GUI su popping up.
- The package build-depends on (and indeed appears to require) libopensc2-dev,
  which unfortunately is no longer available in Debian. Could you find a way
  around that, given that you are upstream? Otherwise please speak to the opensc
  maintainer in Debian about this.

Thanks a lot for your work,
Michael

Attachment: pgp7jTGaSbJqw.pgp
Description: PGP signature


Reply to: