Thanks for your review! On Mon, 25 Jul 2011 12:44:49 +0300 "Eugene V. Lyubimkin" <jackyf@debian.org> wrote: > [ I prefer to have a bumped package version after an each review ] Other mentors have preferred that I use the VCS for keeping track of pre-release changes and leave the changelog clean, with only the "Initial release (Closes: #ITP)" entry. As a relative neophyte to the Debian packaging-and-policy world, I'm not sure what the best way to approach this is. Can you clarify this? > ------- > libbs2b > ------- > > 1) there is definitely something wrong with > remove_win32_build_instruction patch, its size is more than 2 MiB > and it includes some autotools stuff; It looks like things got out of hand when I was trying to get rid of the win32/ directory to avoid some binary blobs. I've made this much cleaner by removing everything from this directory *except* the makefiles, which aren't run anyway as we're not building in a Windows environment, and leaving all the makefile contents alone. Everything is now handled in debian/rules:get-orig-source, so no patch is needed at all. > 2) Vcs-* fields point to LADSPA plugin repository; Derp. Fixed. > 3) debian/copyright: > 3.1) there is no m4/pkg.m4 source file; > 3.2) build-aux/* copyright years should be at least 1996-2010; > 3.3) aclocal.m4, */Makefile.in: is automatically generated, does not > need the entry; > 3.4) configure: copyright years should be 1992-2010. All fixed. > ----------- > bs2b-ladspa > ----------- > 2) debian/copyright: > 2.1) s!Files: *!Files: src/plugin.c! ; > 2.2) spurious 'Copyright 2009 Boris Mikhaylov' (copy leftover?); > 2.3) same (or about the same) corrections as in libbs2b's > debian/copyright. All fixed. I've gone ahead and uploaded the fixed version to mentors without bumping the version number for now, so you and other mentors can see the code changes if interested. Thanks again for your help! --Andrew
Attachment:
signature.asc
Description: PGP signature