Re: RFS: phing (Another try)

[Benoît Knecht <benoit.knecht@fsfe.org>]

Hi Nicolas,

Nicolas wrote:
> Hi all,
> 
> thanks Benoît. I updated the package following your advices.
> 
> I uploaded it on mentors and push my changes on the git repository.

There are still a few things that need to be fixed:

  - debian/phing.1 still contains the BUGS section I mentioned
    previously.

  - Your debian/copyright file is still not DEP-5 compliant. To repeat
    what I said before, it "doesn't use a versioned Format URL; in the
    latest version of DEP-5, the Name and Maintainer fields do not
    exist."

    Instead of repeating the LGPL-3 twice, you should put it in a
    stand-alone license paragraph.

    "All rights reserved" is not a license. I've checked the fist two
    files you list under that license, they seem to be LGPL. Don't
    include "@copyright" in the Copyright field.

    You need a stand-alone license paragraph for the Apache and Expat
    licenses.

Cheers,

-- 
Benoît Knecht