Re: RFS: phing (another try)

[Federico Giménez Nieto <federico.gimenez@gmail.com>]

Hi Nicolas, here are my comments about your work (i'm not a DD):

  -debian/control: since you specify '3.0 (quilt)' in debian/source/fomat, there is no need for a
quilt dependency

  -debian/copyright:
      -Executing from the sources directory:

        $ grep -r copyright .

      you get, among others:
        ./classes/phing/parser/AbstractHandler.php: * @copyright 2001,2002 THYRELL. All rights reserved
        ./classes/phing/tasks/ext/jsmin/JsMin.php: * @copyright 2002 Douglas Crockford
<douglas@crockford.com> (jsmin.c)
        ./classes/phing/tasks/ext/jsmin/JsMin.php: * @copyright 2008 Ryan Grove <ryan@wonko.com>
(PHP port)
        ./classes/phing/filters/TailFilter.php: * @copyright 2003 seasonfive. All rights reserved

      All the copyright holders must be included in the copyright file. You could also try executing
'grep -r apache .'

      -You could specify the copyright notice of the packaging itself (set by you for your work)

  -debian/rules: as above, you should remove all quilt-related commands, the simplest rules file
should work in this case

  -lintian reports duplicated files in /usr/share/doc/phing, you should check it (i've noticed it
running 'lintian -iIEvXcF --pedantic phing_2.4.5-1_i386.changes')

Thanks,
Federico