[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: s3ql (new python application)



Nikolaus,

On Tue, 2011-06-28 at 14:56 -0400, Nikolaus Rath wrote:
> dget http://mentors.debian.net/debian/pool/main/s/s3ql/s3ql_1.0.1-1.dsc

thanks for the update.

1. Regarding the example scrips you ship I'm sort of undecided whether
they would actually fit better in examples rather than "contrib". I
guess yes.

 usr/share/doc/s3ql/contrib/benchmark.py
 usr/share/doc/s3ql/contrib/expire_backups.py
 usr/share/doc/s3ql/contrib/make_dummy.py
 usr/share/doc/s3ql/contrib/pcp.py
 usr/share/doc/s3ql/contrib/s3ql_backup.sh

2. You symlink your contrib scripts from /usr/share/doc (!)
into /usr/bin which is not really the best solution out there. Please
decide whether these shall either go as examples (and not symlinked
to /usr/bin/) or whether they are official applications - in which case
they don't belong into /usr/share/doc.

Anyway, built, signed, uploaded.

As we'll be landing in NEW anyway, please prepare any new upload with
1.0.1-2 version fixing these bugs. We don't even need to wait until
we'll be accepted from NEW into main to push this into incoming.

Thanks!

-- 
Cheers,
Kilian

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: