[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: klatexformula [rt.phys.ethz.ch #71163]

Hi Tobias and Philippe,

I just have been pointed to the klatexformula RFS by my coworker
Gürkan Sengün.

Since we want klatexformula as Debian package also at work (Dept. of
Physics, ETH Zürich), I'll happily sponsor the package.

I just reviewed the package available at
http://mentors.debian.net/debian/pool/main/k/klatexformula/ (version
3.2.2-1 from 26-Dec-2010)

Despite Tobias already did a great job in fixing all the issues
already mentioned on debian-mentors, I still have a few remarks about
the packaging as well as the software itself.

Nevertheless most of them should be easily to fix anyway. First some
comments by Lintian (including informational and pedantic messages :-):

For Tobias to fix:

I: klatexformula source: debian-watch-file-is-missing
N:    This source package is not Debian-native but it does not have a
N:    debian/watch file. This file is used for automatic detection of new
N:    upstream versions by the Debian External Health Status project and other
N:    project infrastructure. If this package is maintained upstream, please
N:    consider adding a debian/watch file to detect new releases.
N:    If the package is not maintained upstream or if upstream uses a
N:    distribution mechanism that cannot be meaningfully monitored by uscan
N:    and the Debian External Health Status project, please consider adding a
N:    debian/watch file containing only comments documenting the situation.
N:    Refer to Debian Policy Manual section 4.11 (Optional upstream source
N:    location: debian/watch) and the uscan(1) manual page for details.
N:    Severity: wishlist, Certainty: certain

debian/watch files help Debian to notice when new upstream versions
are available. Please include one.

I: klatexformula: arch-dep-package-has-big-usr-share 3147kB 56%
N:    The package has a significant amount of architecture-independent data
N:    (over 4MB, or over 2MB and more than 50% of the package) in /usr/share
N:    but is an architecture-dependent package. This is wasteful of mirror
N:    space and bandwidth since it means distributing multiple copies of this
N:    data, one for each architecture.
N:    If the data in /usr/share is not architecture-independent, this is a
N:    Policy violation that should be fixed by moving the data elsewhere
N:    (usually /usr/lib).
N:    Refer to Debian Developer's Reference section 6.7.5
N:    (Architecture-independent data) for details.
N:    Severity: wishlist, Certainty: certain

Fixing this would help to reduce the size of the binary package on the
mirrors. This no problem for a first upload to unstable, but it should
be fixed for the next Debian stable release, i.e. when the packages
will stay for quite some time on the mirrors.

But be aware that changing this after the package has been uploaded in
Debian means that the package will have to go through throug NEW a
second time.

I: libklatexformula3: no-symbols-control-file usr/lib/libklfbackend.so.3.2
I: libklatexformula3: no-symbols-control-file usr/lib/libklfapp.so.3.2
I: libklatexformula3: no-symbols-control-file usr/lib/libklftools.so.3.2
N:    Although the package includes a shared library, the package does not
N:    have a symbols control file.
N:    dpkg can use symbols files in order to generate more accurate library
N:    dependencies for applications, based on the symbols from the library
N:    that are actually used by the application.
N:    Refer to the dpkg-gensymbols(1) manual page and
N:    http://wiki.debian.org/UsingSymbolsFiles for details.
N:    Severity: wishlist, Certainty: certain

Nice to have, but not necessary for a first upload.

W: libklatexformula3: package-name-doesnt-match-sonames libklfapp3.2 libklfbackend3.2 libklftools3.2
N:    The package name of a library package should usually reflect the soname
N:    of the included library. The package name can determined from the
N:    library file name with the following code snippet:
N:     $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | sed -e's/\([0-9]\)\.so\./\1-/; s/\.so\.//'
N:    Refer to Debian Library Packaging Guide chapter 5 (shared library
N:    packages) for details.
N:    Severity: normal, Certainty: possible

I suppose splitting up the package into three library packages doesn't
make much sense in this case, but "libklatexformula3.2" may be a
better fitting package name. The relevant link for this is:
(Philippe: Or do you think using one of those libraries without the
others would make sense in some cases?)


| Copyright: 2005, Philippe Faist <philippe.faist@bluewin.ch>

This probably should be "2005-2010" or so instead of just "2005". (I
found copyright notices by Philippe at least from 2007 throyugh 2010.)

Then I found this copyright statement not mentioned in

./src/modeltest.h:** Copyright (C) 2007 Trolltech ASA. All rights reserved.

For Philippe to fix in a later version of klatexformula:

I: klatexformula: spelling-error-in-binary ./usr/bin/klatexformula preceeded preceded
I: klatexformula: spelling-error-in-binary ./usr/bin/klatexformula ressource resource
I: libklatexformula3: spelling-error-in-binary ./usr/lib/libklfapp.so.3.2 Langugage Language
I: libklatexformula3: spelling-error-in-binary ./usr/lib/libklfapp.so.3.2 an other another
N:    Lintian found a spelling error in the given binary. Lintian has a list
N:    of common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:    If the string containing the spelling error is translated with the help
N:    of gettext or a similar tool, please fix the error in the translations
N:    as well as the English text to avoid making the translations fuzzy. With
N:    gettext, for example, this means you should also fix the spelling
N:    mistake in the corresponding msgids in the *.po files.
N:    You can often find the word in the source code by running:
N:     grep -rw <word> <source-tree>
N:    This tag may produce false positives for words that contain non-ASCII
N:    characters due to limitations in strings.
N:    Severity: minor, Certainty: wild-guess

Would be nice if they would be fixed in some future release.

Oh, and one comment about klatexformula's user interface in general:

I find it very annoying that klatexformula uses a fixed-size window
you can't resize. This makes klatexformula very cumbersome to use with
e.g. tiling window managers. So I would be happy if this could be
changed in future versions of klatexformula.

Summary: At least debian/copyright and debian/watch should be fixed
for sponsoring.

		Regards, Axel
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5

Reply to: