Re: RFS: enemy-territory
On Mon, 21 Feb 2011 11:52:08 +0100, Alessandro Ghedini wrote:
> Hello,
>
> On Sun, Feb 20, 2011 at 08:03:41PM -0500, Michael Gilbert wrote:
> > I am looking for a sponsor for my package "enemy-territory".
> >
> > * Package name : enemy-territory
> > Version : 2.60-1
> > Upstream Author : id Software / Splash Damage
> > * URL : http://www.slashdamage.com/content/wolfenstein-enemy-territory-barracks
> > * License : GPL-3, md4 RSA, zlib
> > Section : contrib/games
> >
> > It builds these binary packages:
> > enemy-territory - GPL version of the id Software game Enemy Territory
> >
> > The package appears to be lintian clean.
> >
> > The upload would fix these bugs: 606931
> >
> > My motivation for maintaining this package is: I like this game, and now that its
> > GPL'd having a package available for users will be very nice.
>
> The debian/copyright seems incomplete. You should add the copyrights and
> licenses for all the bundled libraries (even if they are not used to build
> the package):
> - src/curl-7.12.2
> - src/ft2
> - src/jpeg-6
>
> Plus some files under src/mac:
> - src/mac/glext.h
> Copyright: 1999-2010 id Software LLC, a ZeniMax Media company
> 1999 by Apple Computer, Inc., all rights reserved
> 1991-2000 Silicon Graphics
> - src/mac/CarbonMouse.cpp
> Copyright: 2001-5 Aspyr Media
> 1999-2010 id Software LLC, a ZeniMax Media company
>
> It is also a good idea to use the machine-readable DEP5 format [0] to write
> debian/copyright (not strictly required though).
>
> In addition there are some lintian I and P tags:
> I: enemy-territory source: debian-watch-file-is-missing
> P: enemy-territory: no-upstream-changelog
> I: enemy-territory: spelling-error-in-binary ./usr/lib/enemy-territory/et.x86
> succesfully successfully
> I: enemy-territory: spelling-error-in-binary ./usr/lib/enemy-territory/et.x86
> unkown unknown
> I: enemy-territory: spelling-error-in-binary ./usr/lib/enemy-territory/etded.x86
> succesfully successfully
> I: enemy-territory: spelling-error-in-binary ./usr/lib/enemy-territory/etded.x86
> unkown unknown
>
> (the upstream changelog can be found under src/docs, the watchfile is IMHO
> not really needed since probably the sources won't get update).
>
> I am not a DD anyway, so I can't sponsor your package :)
Thanks for your feedback :) These seem like good changes to make, and
I will fix them.
Best wishes,
Mike
Reply to: