Re: RFS: rman (updated package)
Hi, Niels,
I have re-uploaded that.
Thanks.
Anton
On Tue, Jan 18, 2011 at 10:44 AM, Niels Thykier <niels@thykier.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 2011-01-17 22:04, Anton Gladky wrote:
>> Hi, Niels,
>>
>
> Hey
>
>> I have uploaded a new version of rman. Could you not, please, have a look?
>> It seems, that I have fixed all issues, which were suggested by you.
>>
>
> Sure; I have a question to the realloc replacement. It seems like your
> replacement will be unable to handle if there was not enough memory in
> the first iteration.
>
> @@ -4615,10 +4615,10 @@ char *
> filesuck(FILE *in) {
> const int inc=1024*100; /* [...] */
> int len=0,cnt;
> - - char *file = malloc(1); /*[...] */
> + char *file;
>
> do {
> - - file = realloc(file, len+inc+1); /* w[...] */
> + file = malloc(len+inc+1); /* [...] */
> cnt = fread(&file[len], 1, inc, in);
> len+=cnt;
> } while (cnt==inc);
> - ----
>
> I believe the following pattern can be used to solve the original problem.
>
> char *tmp = realloc(file, len + inc + 1);
> if(!tmp) { free(file); <fail-in-a-sane-way>; }
> file = tmp;
>
>> I did not sent a patch, which fixes cppcheck warnings, to upstream as
>> those warnings were done by adding gzip-feature to the code (probably,
>> maintainer).
>>
>
> Admittedly upstream looks rather dead. :)
>
>> Thank you.
>>
>> Anton
>>
>> [...]
>
> Also, please change "unstable" to "experimental" in the changelog.
> Without approval from the Release Team we cannot upload to unstable this
> deep in a freeze. It can easily be re-uploaded to unstable when the
> freeze is over.
>
> There are also a couple of Lintian info tags. About the no-doc-base I
> think it is related to the removal of d/rman.doc-base.manual (though
> honestly I did not check your binary package with Lintian the last
> time). Note these are only emitted by Lintian with the extra flags (-I
> in the particular case), since they are more pedantic or less serious
> than other tags.
>
> I: rman: possible-documentation-but-no-doc-base-registration
> I: rman: spelling-error-in-manpage usr/share/man/man1/rman.1.gz
> extention extension
> I: rman: example-wrong-path-for-interpreter
> ./usr/share/doc/rman/examples/hman.cgi (#!/usr/bin/ksh != /bin/ksh)
> I: rman: example-wrong-path-for-interpreter
> ./usr/share/doc/rman/examples/hman.ksh (#!/usr/bin/ksh != /bin/ksh)
> I: rman: example-wrong-path-for-interpreter
> ./usr/share/doc/rman/examples/man2html (#!/usr/bin/ksh != /bin/ksh)
>
>
> I think that is about it. :)
>
> ~Niels
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBCAAGBQJNNWEOAAoJEAVLu599gGRC3dQQAKz9iGQyCJSMVF+51F8j+lwq
> bpARdvr/O/Sj/YRDdkdqKHPID61klXHMRla/GKxnNBRoDCbDJE6R+VCLouUmTXwF
> u1Bvwo7tOX1S4dNv+tf9IEZ30nLgvUDWjRKTC1bi308wSdxnElEwT+ec2hK0o942
> X5n4i7761C3/vBdI9r9NeA1A77EAJDTlAozyG/zcPUTQ+tUFW6HUMFP4lCsU4ZE2
> mnrUb9T6+yufs84ldmRW3FdLOKukX0bBHEVB+pDy4W114kKkG3AC/BzyytS15gGR
> /6E8A5LmXH01VPIVLpqs5Xdu5lqni8bDsAWJM6lIMpY7oFPP+rR4DH0jwvcpuE5q
> QTg24yuMHriWb8XMOfoaDcgqAR5Tm+1P22NU+bRfeLF0Bzo/hlggG5Lrp56m7dqe
> MEV1oc68yulMCcMPBfQp0r86cXxzMnaPtf4SxA3gHesGFvb8r/qS47unnwfJZJpv
> pvh/k9zWHA1C08nkhrSkn8XWthdAXg/3bYj7PdGuzYAEwJMQAMbPVHiFvGnFi0Vi
> umLNfZTnmg0Fj+6JQ9nvpzL/YIwy4GxUpi6f53YHekhhkX8vcy71OrN+rlGV2Qkz
> KcCDonqo9CctSqLO5lTDTucJTLZQI3qBvG4B0jk4aXrOlC5aLnYKbiH1LHRSu9fF
> l9IFOzascmvgjaLk3FcC
> =GjPn
> -----END PGP SIGNATURE-----
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] 4D35610F.6050004@thykier.net">http://lists.debian.org/[🔎] 4D35610F.6050004@thykier.net
>
>
Reply to: