Re: RFS: rman (updated package)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 2011-01-09 10:33, Anton Gladky wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 3.2-5
> of my package "rman".
>
> It builds these binary packages:
> rman - PolyglotMan - Reverse compile man pages
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 358478, 465951, 530329
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/r/rman
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/r/rman/rman_3.2-5.dsc
>
> I would be glad if someone uploaded this package for me.
>
> Kind regards
> Anton Gladky
>
>
Hey
Thanks for your interest in this orphaned package.
cppcheck reports a few issues that should probably be patched and sent
upstream:
$ cppcheck rman.c
Checking rman.c...
[rman.c:4621]: (error) Common realloc mistake: "file" nulled but not
freed upon failure
[rman.c:3981]: (error) Mismatching allocation and deallocation: proc
[rman.c:3987]: (error) Mismatching allocation and deallocation: proc
[rman.c:3995]: (error) Mismatching allocation and deallocation: proc
You should also have a look at d/rules. Currently it builds d/copyright
from d/copyright.prefix and README-rman.txt and also removes d/copyright
in the clean rule.
Personally I would prefer if the patches were separated into "related
changes". (e.g. the "debian-changes-before-3.2.5" could be split into
one that fixes #! lines, one that adds the GZIP stuff and one that
modifies the man pages etc.)
It is not a requirement, but it makes the patches easier to maintain.
Finally - this upload is targeted for unstable. Since Squeeze is
frozen, the Release Team should approve the upload. Alternatively you
can target experimental, which is always okay.
~Niels
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJNMDD4AAoJEAVLu599gGRCQQgQAKlF9ScDohZABa3csotNW77m
dQzdi12z+4lb2OuUATPhj9tlUizEifvR0jJkVezlgPNirirVS0MTbMZq9uod+dgr
JD99Ho0yGb+DGoXo26joMGqehwexx4h1VKQ0ATyHiUBLIdGqKsI8HkdPoGm0+D5+
FQA6XKHgX6FQlfSayDkUK9q7zFDB8fRI2OrPFcY9aSs3iiloO5K7VaqyaOIZm8Oc
NZatADVNG8fkyJsgT2SoGnduTbPNjkriLlV3ZQ1PcRy3upvokOdholYbknrMKsGg
g8tcEgCSkhsemw/A0QWnHgoQex4Bd+RRBzVQVNCZV0xi6srYKYDpU1bqvN7fMx9C
bMc6jdloxLs7pXJr1BrBgGMjbHzn7+tDZlkWyFwIlNgTlU9oqerD4XPQd7YhxOZb
oyshH51B1ZdcB6D42GUrtV+TQA8P1596Bz5mOsVyhpLBVlksB24uHTjEoUw5hyXh
HMUcOP95+ZJNOY+ZymBrgvJeKvmeC7V1hs7yON2FRDfo3Q3oI2oYkEAKYq+sKHQ2
utMAYLU6LmBDYQIsrqxHfvKWlQoa0iTvZKRU+rQHp7UhZOX3T61pJ1U1L1jf5cmc
LDH3iFMcFfGEPnUgTEPgtciT3hEmogZm4pKrM+e3YAi/sp5AVLaIURlE0jRtEgx7
sZqHwoPiG9bsfErdm0qA
=JwW5
-----END PGP SIGNATURE-----
Reply to: