Re: RFS: mobile-broadband-provider-info (updated package)
On Thu, Aug 26, 2010 at 8:09 AM, Paul Wise <pabs@debian.org> wrote:
> On Wed, Aug 25, 2010 at 6:15 PM, Julien Cristau <jcristau@debian.org> wrote:
>> On Wed, Aug 25, 2010 at 10:50:53 +0530, Bhavani Shankar R wrote:
>>
>>> henceforth I am attaching the diff from the present version in
>>> sid/squeeze for your kind review
>>>
>> Looks ok for a freeze exception. Please let -release know when the
>> package is accepted in the archive.
>
> Please fix the following issues and I will upload it:
>
> Please close the relevant Launchpad bugs in the changelog using (LP:
> #1234) so that once Ubuntu syncs the package, the relevant bugs will
> be automatically closed. You can find the relevant Launchpad bugs in
> the upstream git log.
Okay sure paul!
> You also added a love poem in 'debian/new file', I would suggest that
> is not useful in a source package and should be removed, cute though
> it is :)
Sorry! it was added by mistake :)
> The following issues are not blockers for this upload:
>
> Since upstream uses autotools, you can use 'make distcheck' to create
> the tarball in debian/rules get-orig-source. Then let upstream know if
> that fails or produces a different tarball than what you need for
> Debian. The default upstream tarball format seems to be .tar.bz2 so
> you will need to add a bunzip2 > ...tar.bz2 | gzip -9 > ...tar.gz to
> the process at least until post-squeeze when you could switch to
> dpkg-source v3 (IIRC the release team prefers not to unblock
> dpkg-source format version changes).
>
> I just noticed that the version number is incorrect since upstream
> hasn't bumped the version in configure.ac, please talk to upstream
> about that. Probably the version number needs to be autogenerated
> based on the date of the latest git commit when the tarball is
> generated with "make distcheck".
>
> The upstream source still contains references to SVN, but it is now
> maintained in git, you might want to poke them about that.
>
> Upstream might want to look at CC0, which is a more internationalised
> version of CC-PD.
>
> --
> bye,
> pabs
>
> http://wiki.debian.org/PaulWise
>
--
Bhavani Shankar.R
https://launchpad.net/~bhavi, a proud ubuntu community member.
What matters in life is application of mind!,
It makes great sense to have some common sense..!
Reply to: