Re: RFS: xsublim
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thank you for pointing out all the flaws.
On 2010-08-21 01:12, Luke Faraone wrote:
> On 08/20/2010 04:31 PM, Markus Schulz wrote:
>> This has been updated to 2.0.3-1 and I changed the section to X11. Is
>> there anything wrong with this package? Please help, thank you.
>
> Your "Upstream Author(s)" section is a duplicate of the immediately
> following section which is "Copyright".
fixed
> Secondly, "Author(s)" should be
> corrected to the proper tense.
fixed
> Use © instead of (C). [wishlist]
fixed
> Your first changelog entry should not contain other items other than
> "Initial release. (Closes: #nnnnnn)". Nix these:
> """ * Add GNU build environment
> * This is my first Debian package.
> * Shows now the whole phrases by default
> * xsublim release without xscreensaver, it's based of xscreensaver 5.06
> * new options --wordmode and --offsetx/offsety and --oneshot
> * add xwinwrap for compiz issues
> """
fixed
> Also, please update your standards version. 3.8.4 is a bit old now.
fixed
> Your description reads a bit oddly:
>
>> Description: Display "subliminal" messages on your screen
>> By default it shows positive affirmations messages just for a split second on
>> your screen. The messages goes in to your subconsciousness and your start
>> believing it.
>> xsublim was originally developed by Greg Knauss in ANSI C, and it utilities the
>> X11 library to display the messages on the screen.
>
> Perhaps a rewording would be good:
>
> Description: display "subliminal" messages under X11
> xsublim utilities the X11 library to quickly flash messages on the
> screen. By default it shows "positive affirmations" which are designed
> to be picked up by the user's subconcious and internalized.
>
> Who authored a package usually isn't worth mentioning in a description
> unless there are a number of similar packages by different authors. (ie.
> tftpd-hpa)
fixed, here is what I use now:
Description: display "subliminal" messages under X11
xsublim uses the X11 library to quickly flash messages on the
screen. By default it shows "positive affirmations" which are designed
to be picked up by the user's subconcious and internalized.
Thanks,
Markus Schulz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkxwCz8ACgkQAw59umMzoQSNtQCfd5YkrohF+Y2V940VPYh7eVkq
hjAAnRAvmwO501n5DkCwATPxzgQUceYW
=m2/e
-----END PGP SIGNATURE-----
Reply to: