[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: xsublim



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 08/20/2010 04:31 PM, Markus Schulz wrote:
> This has been updated to 2.0.3-1 and I changed the section to X11. Is
> there anything wrong with this package? Please help, thank you.

Your "Upstream Author(s)" section is a duplicate of the immediately
following section which is "Copyright". Secondly, "Author(s)" should be
corrected to the proper tense.

Use © instead of (C). [wishlist]

Your first changelog entry should not contain other items other than
"Initial release. (Closes: #nnnnnn)". Nix these:
"""  * Add GNU build environment
  * This is my first Debian package.
  * Shows now the whole phrases by default
  * xsublim release without xscreensaver, it's based of xscreensaver 5.06
  * new options --wordmode and --offsetx/offsety and --oneshot
  * add xwinwrap for compiz issues
"""

Also, please update your standards version. 3.8.4 is a bit old now.

Your description reads a bit oddly:

> Description: Display "subliminal" messages on your screen
>  By default it shows positive affirmations messages just for a split second on
>  your screen. The messages goes in to your subconsciousness and your start 
>  believing it.  
>  xsublim was originally developed by Greg Knauss in ANSI C, and it utilities the 
>  X11 library to display the messages on the screen.

Perhaps a rewording would be good:

Description: display "subliminal" messages under X11
 xsublim utilities the X11 library to quickly flash messages on the
 screen. By default it shows "positive affirmations" which are designed
 to be picked up by the user's subconcious and internalized.

Who authored a package usually isn't worth mentioning in a description
unless there are a number of similar packages by different authors. (ie.
tftpd-hpa)

Thanks,

╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJMb2BFAAoJEJcyXdj5/dUGU3oQAMHGM/fMF1TET2z/CdOoelin
h8vs5K4TOVNBdrL3BUdzyoE7T0EwNtoCn8cu+LXvItNTIDfyIPm6KLoJTY4QpZW1
kTm3lTO6aQqEp+4vCTewQAfooi4MHUMAKZ2qOamYviZ/wIzaQYCLkS/eNEHninhL
djfUstsHpSRaW0bTcftjkZsedlyok+FeZlJF4fWECH9e/UzavEFKEMRNkOBDDWHE
ZmmH3dFURXplIqkpNdAz88Gz3g4+tz8gVKla+G8Myjk4WQeJe4ISqVD/DGZkLaYA
x2VBhPDfxfVNwDqMmGe1jcyMZxquw3KaFG51V59KPon3KPRX+ut12lOB+r6xMUuU
tDl/bzzVRvQLBbA4W1adLh44sSDZpsytlEk0l5SFOx0EPYtFX63FQuNw5H7aPKoV
2YVj8NaKxlnt2up0cpKU9I1eAVp/TBOScl7PTQhNlA87gLQfnF65UKNdabccgYoD
uOLEisNvvfFr+Wbfsjjr0Chzs2js9b18WeLurlk90yfFcKKIsPDp57UJc5kroZA+
tO5M5jENGYYjACDLyHLvIvPvKeoFwoZNexOHVozwD8nMJllOTQKWPTtaQlw3xcto
udloYa/OSjKf+LU8yNnznT/UiXhqq8bxrFoMOJDUAZF9Pm/IKWJwGsiTueF95nsB
+2syCTOA8S7hZ8czARrb
=dkgK
-----END PGP SIGNATURE-----


Reply to: