Re: RFS: egroupware (fixes critical bug)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Michal,
thanks for your reply. I've added comments to the various lintian errors
right below.
>> The packages are based on previous work by Peter and were only
>> changed to include the latest upstream version.
>
> It would be good to fix some Lintian warnings as well:
>
> P: egroupware-egw-pear source:
> direct-changes-in-diff-but-no-patch-system
> egw-pear/HTTP/WebDAV/Server.php and 5 more
egroupware-egw-pear contains copies of pear modules, which are needed
for egroupware to run. Some of those modules have been touched by Peter.
However I don't think they will be updated to newer upstream versions
anywhere soon. Therefore I added an override for this.
> W: egroupware-egw-pear source: out-of-date-standards-version 3.8.2
> (current is 3.8.4)
Fixed.
> W: egroupware source: out-of-date-standards-version 3.8.2 (current is
> 3.8.4)
Fixed.
> I: egroupware-core:
> possible-documentation-but-no-doc-base-registration
> I: egroupware-etemplate:
possible-documentation-but-no-doc-base-registration
Those errors were already present, but I don't know how important they
are. Do I have to fix them?
> I: egroupware-core: unused-debconf-template egroupware/configuration/note
> I: egroupware-core: unused-debconf-template
egroupware/header/password/mismatch
It is used in egroupware-core.config, however this is not detected by
lintian. Should I add an override or is this a bug in lintian?
> I: egroupware-addressbook: debian-news-entry-without-blank-line line
> 6
Fixed.
> P: egroupware-*: no-upstream-changelog
I've read http://lintian.debian.org/tags/no-upstream-changelog.html and
noticed the sentence about multiple binary packages produced from a
single source. However in the upstream tarball several Changelog files
are located troughout the source tree, some of which have not been
touched for several years. I'll try and ask the egroupware developers to
add a central changelog to their released tarballs, which I can then
link/copy or place in the main egroupware-core package.
As I did not change anything here, I assume that those errors were
present before. I'd like to address them in future. Please let me know
if you think they are important enough to prevent the package from being
accepted.
> P: egroupware-felamimail: copyright-refers-to-symlink-license
> usr/share/common-licenses/LGPL
The file in question is from the horde project, which linked to the LGPL
at http://www.fsf.org/copyleft/lgpl.html . I think this justifies
symlinking to the latest version of LGPL, but of course I can change it
to whatever seems more appropriate. I didn't change this as well.
> W: egroupware-core: embedded-php-library W: egroupware-core:
> embedded-javascript-library W: egroupware-phpsysinfo:
> embedded-php-library W: egroupware-projectmanager:
> embedded-php-library W: egroupware-projectmanager:
> duplicate-font-file
All errors above were already present in the debian packages built by
Peter, so I assumed, it might be OK to leave them untouched. Especially
as fixing them would inflict a lot of work and I suspect would also
cause version conflicts between the current versions in debian and the
versions needed by egroupware (except maybe for the fonts). Shall I add
them to overrides then?
I hope my comments clear out some of the concerns. Where possible I
added a fix and uploaded new versions of the packages. Regarding all
other problems, I'm open for any comment or discussion. Thanks for your
help.
With kind regards,
Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkwctPEACgkQjkLYWQtVFRoy2wCfY4sfmcgyZwt0IbV2kjH250EK
tsYAn0SK6JOVINvhVoeFWTcQn5jf0bNY
=B/32
-----END PGP SIGNATURE-----
Reply to: