Re: RFS: emu8051

I am not a devian developer, so I can not sponser your upload, however
here are some comments:
debian/control: XSBC-original maintainer is a field only used by
ubuntu, remove it
section: I would use 'Electronics'

Hello Johan,
This package was initially packaged in ubuntu so when porting to debian I added a user defined field called Original-Maintainer as per policy to reflect that
Refer:
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s5.7

and I will update the section field thanks!

debian/copyright:
your last lines read:
License: GPL-2
The Debian packaging is hereby placed in the GPL-2 (no rights
reserved).
I'm not a lawyer, but I would either put your debian packaging under
the GPL-2 or release it in the public domain (no rights reserved).
Now they conflict.

I ll put it under public domain! thanks

build system:
consider using debhelper 7 instead of cdbs, as this is what most new
packages use. The minimal rule should work fine
/usr/share/doc/debhelper/examples/rules.tiny

I ll switch over and upload!

src/Makefile.am consider adding --as-needed to your link flag when
using gtk (send this upstream)
17: emu8051_LDADD = $(GTK_LIBS) -Wl,--as-needed

thanks for the catch ll contact the upstream maintainer

Lastly, my most important comment: I recommend you to join the
pkg-electronics team, and to request sponsorship there:
http://wiki.debian.org/PkgElectronics

Sure! thanks for the review!

On Thu, Jun 10, 2010 at 6:47 PM, Bhavani Shankar R <bhavi@ubuntu.com> wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "emu8051".
>
> * Package name : emu8051
> Version : 1.1.0-1
> Upstream Authors : Hugo Villeneuve <hugo@hugovil.com>,
> Jonathan St-André <standr00@gel.ulaval.ca>
> * URL : http://www.hugovil.com/en/emu8051/index.html
> * License : GPL-2
> Section : x11
>
> It builds these binary packages:
> emu8051 - Emulator and simulator for 8051 microcontrollers
>
> The upload would fix these bugs: 585446
>
> My motivation for maintaining this package is: I m an electrical engineer by
> profession and I ve experience working on Intel 8051 and ARM
> Microcontrollers and since the usage of the program is simple(It loads Hex
> files and it executes the program continuously till the desired output is
> got) and since this is my specific area of interest I would like to maintain
> this package in debian.
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/e/emu8051
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
> contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/e/emu8051/emu8051_1.1.0-1.dsc
>
> I would be glad if someone uploaded this package for me.
>
> Regards
>
> --
> Bhavani Shankar.R
> https://launchpad.net/~bhavi, a proud ubuntu community member.
> What matters in life is application of mind!,
> It makes great sense to have some common sense..!
>
>