Re: RFS: liboauth (Updated Package)
On Thu, Jun 10, 2010 at 9:28 PM, Bilal Akhtar <bilalakhtar96@yahoo.com> wrote:
> I am looking for a sponsor for my package "liboauth".
Have you read libpkg-guide?
You hard-code dependencies on libcurl3, libnss3-1d. Please let the
shlibs mechanism deal with that.
In debian/rules, I'd recommend replacing the ./configure call with this:
dh_auto_configure -- --enable-nss
If you do, I think you can drop the DEB_* lines too.
Please send upstream a patch to fix make distclean so you don't need
to override override_dh_auto_clean.
Please ask upstream to use the standard sourceforge file release and
mirror system.
Insert my standard comment about library package descriptions, think
about the audience for each one. -dev package will be manually
installed by people developing apps using liboauth and also as part of
build-depends. liboauth0 should only be installed automatically so it
doesn't need a verbose description.
Why do you build-depend on automake/autoconf but don't run them in the
build process?
Do you need to install the static library and .la file? Debian seems
to be moving towards not installing either of these.
No need to be so specific with the manual page path, usr/share/man/
should do it.
Should you be depending on locales/locales-all too?
dpkg-shlibdeps warnings:
dpkg-shlibdeps: warning: symbol curl_slist_free_all used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol curl_slist_append used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol PK11_DigestBegin used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol curl_easy_cleanup used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol PK11_DigestOp used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol SECKEY_DestroyPrivateKey used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol PK11_DestroyContext used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol VFY_VerifyData used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol PK11_DigestFinal used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: symbol PK11_FreeSymKey used by
debian/liboauth0/usr/lib/liboauth.so.0.6.0 found in none of the
libraries.
dpkg-shlibdeps: warning: 17 other similar warnings have been skipped
(use -v to see them all).
lintian complaints:
X: liboauth0: shlib-calls-exit usr/lib/liboauth.so.0.6.0
I: liboauth0: no-symbols-control-file usr/lib/liboauth.so.0.6.0
Some of the above is copied verbatim from my previous review. Please
address everything in a review before posting another RFS.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: