Re: RFS: marave - 2nd Attempt
On Tue, Jun 8, 2010 at 6:25 AM, Chris <racerx@makeworld.com> wrote:
> I am looking for a sponsor for my package "marave".
Here is a review:
Since this is an editor and we have tons of those in Debian, your RFS
and package description should detail what marave does that others do
not.
According to the upstream README, there are some non-free files to remove:
marave/backgrounds/Winter Landscape Classic.jpg
marave/backgrounds/Dutch winter landscape.jpg
marave/backgrounds/Landscape with sky.jpg
marave/clicks/thozi_daCLick.wav
marave/clicks/adriantnt_u_click.wav
marave/clicks/adriantnt_r_plastic.wav
IIRC all Partners in Rhyme stuff is non-free, please clarify with
upstream the exact license that applies to these files:
marave/clicks/BEEP1A.WAV
marave/clicks/BEEP1B.WAV
marave/clicks/BEEP1C.WAV
marave/clicks/CLICK10A.WAV
marave/clicks/SERVO1A.WAV
marave/backgrounds/118222-Just_Green_Curls.svgz is GPL but the SVG
contains a massive embedded PNG file. I seriously doubt that it could
be considered source code, so distributing it is probably a GPL
violation.
The icons are supposedly from the Reinhardt SVG icon set. It would be
best to package that separately and depend on it.
debian/copyright is missing copyright/license information for the
above files as well as these:
marave/plugins/smarty.py
marave/editor/spelltextedit.py
It is best to license debian/ under the same license as upstream so
any files can be included upstream.
Please send the manual page upstream.
Your debian/rules contains some boilerplate text that can be removed.
debian/patches/debian-changes-0.7-1 should be renamed to something
sane, have DEP-3 compliant headers added and the existing header
removed. You might want to ask upstream to include the ChangeLog that
this patch adds. However, based on the content it should be named
NEWS, not ChangeLog.
I'd encourage you to get your package description reviewed:
http://wiki.debian.org/I18n/SmithReviewProject
Since you bumped the version to -2, please remind potential sponsors
that they need to use the -v argument to dpkg-buildpackage/debuild so
that your ITP is closed properly.
dpkg-gencontrol warning:
dpkg-gencontrol: warning: package marave: unused substitution variable
${python:Versions}
lintian warning:
W: marave: extra-license-file usr/share/pyshared/marave/editor/highlight/LICENSE
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: