[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: trimage



Rogério Brito wrote:
Hi, Kilian.

On Jun 01 2010, Kilian Valkhof wrote:
  
I have updated the short description to "A GUI and command-line
interface to optimize image files via various command line tools" and
pushed these to mentors.debian.net
    
Since the long description mentions how it performs things, you can keep
the short description shorter. BTW, the "A" article could be dropped.
  
"GUI and command-line interface to optimize image files" is it, now.
Also, why is this package native? A native package is, by definition,
one that only matters to Debian and no distribution or operating system
else. You should fix this.
  
I'm new to versioning/packaging, Trimage is my first app and I'm doing this on what I can find online and irc. What does it meant to be a native package? Do I need to change the version number to 1.0.2-1?
The long description should have its lines wrapped. The package browsers
are intelligent enough to know when lines should be wrappred and they
they shouldn't when they display the messages to the users.
  
Thanks, done :)
Nitpick: some consistency in the spaces in the versioned
(build-)dependencies would be good.
  
Fixed, too
I am not exactly sure if you need a build-dependency on python once
python-central is installed (I am not experienced with python), but I
would say that it isn't.
  
I'm using https://launchpad.net/pyapptemplate as a template for my packaging, it has python there. I don't think it does any harm so I'll leave it.
The changelog doesn't close an ITP bug in the first release. Is that
intentional?
  
As I said, I'm doing this on what I can find online. mentors.debian.org seemed to suggest being seperate from submitting an ITP. Do I have to?

Cheers,
Kilian

Reply to: