[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libapache2-mod-geoip (updated package)



On Fri, May 21, 2010 at 10:34 AM, Paul Wise <pabs@debian.org> wrote:

> Anyway, you are the maintainer, that is your decision. Hmm, your new
> changelog says you enabled it but the configuration file still
> comments it out, did you mean to do that?

Clarified on IRC, changelog entry removed.

Package uploaded, please mail this list in future and Thomas, Patrick
or myself will take a look.

Thanks for your contribution to Debian :)

BTW, out of curiosity, I added -Wall to the libtool flags and got
this, please forward upstream:

mod_geoip.c: In function 'geoip_header_parser':
mod_geoip.c:326: warning: implicit declaration of function 'ap_add_common_vars'
mod_geoip.c:301: warning: unused variable 'gip'
mod_geoip.c: At top level:
mod_geoip.c:123: warning: 'create_geoip_server_config' defined but not used

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


Reply to: