Re: RFS: hivex
On Fri, 2010-04-02 at 12:00 +0800, Paul Wise wrote:
> A review of your package:
Great, thanks. As a result I've learned a lot about areas of Debian
packaging I've never really needed to master before, but I've got a
headache and vacant expression to go with it :)
I've uploaded 1.2.1-2 to mentors for further review.
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/h/hivex
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/h/hivex/hivex_1.2.1-2.dsc
I'm keeping track of RFS responses and my actions in the file
debian/Debian-Mentor-RFS-Feedback.txt. This and other superfluous text
files will be removed once the package is ready.
I've figured out how to use lintian now - beforehand I was quite hazy on
it. Aside from some trivial issues (documented in my feedback) none of
the warnings or errors you revealed occur for this build.
Here's a summary of my actions:
* INFO: "debian/copyright-questions.txt", "debian/ubuntu-bug-report-needs-packaging.txt" and "debian/Debian-Mentor-RFS-Feedback.txt"
and other text files are being kept as working notes and records of actions whilst doing the packaging
and will be removed once the package is ready for the 'real' world.
* INFO: lintian override "maintainer-not-full-name" is to make clear I *am* using my *full name* and don't want
to be told "don't use initials" when I'm not (had that several times in past few years with Ubuntu).
* ACTION: Removed comments and blank lines from debian/watch.
* ACTION: Removed "debian/patches/02_Do_not_clean_pkg-config_script.patch": It is the debian/rules clean that is removing
./hivex.pc by doing a "make distclean" on the source. As "./configure" rebuilds it this isn't a real problem except
when building the debian source package.
* TODO: removal of hivex.pc by packaging distclean needs investigating and fixing.
* PENDING: Have mailed the libguestfs list regarding the Makefile patches to fully clean up, and regarding the pod2html
complaints.
UPDATE: upstream replied accepting my Makefile patch "once their git repo is working (hardware problems)". pod2html issues
are caused by a bug in pod2html; upstream author is happy with the output (which is primarily for the libguestfs web-site,
not the binary packages).
* ACTION: Have added Forwarded and Last-Update to "debian/patches/01_Makefiles_clean_all_built_files.patch"
* ACTION: Finally understand what "3.0 (quilt)" means: that there is now an additional <package>-<version>-debian.tar.gz
that contains the debian/ directory. Removed CDBS simplepatchsys rule from debian/rules.
* ACTION: Have mailed the libguestfs list questioning the copyrights: whether the use of GPL v2 is intentional or the result of
template files. Will await a reply before making changes.
UPDATE: reply received: GPL applies to build scripts and programs, LGPL to libraries and bindings. Updated debian/copyright.
* ACTION: rename lib package to libhivex0 to match SO-name of library.
* ACTION: move .a .la static libraries .install rules to -dev package.
* ACTION: remove hard-coded Depends: from binary packages in debian/control.
* ACTION: modified debian/control to avoid lintian duplicate-short-description warnings.
* ACTION: added Section: libdevel to libhivex-dev.
* ACTION: corrected debian/changelog "Closes:" to Debian bug. (originally package for my Ubuntu PPA, hence the LP reference).
* ACTION: moved libhivex.so.0 symlink to -dev package.
* ACTION: generated debian/libhivex0.symbols (relaxed version to 1.2.1 from 1.2.1-1).
* ACTION: changed libhivex-perl to Section: perl.
* ACTION: Debian Perl Policy section 2.3 (http://www.debian.org/doc/packaging-manuals/perl-policy/ch-perl.html#s-paths) seems to
require that perl-module-in-core-directory be resolved by installing these files to the "vendor" location.
* ACTION: added ${perl:Depends} to -perl package as recommended in Perl Policy 4.4.3.
* ACTION: added dh_install excludes for unwanted Perl library files perllocal.pod and .packlist.
* ACTION: added libhivex-ocaml-dev package to contain development files.
* ACTION: added usr/share/locale to debian/hivex.install to install missing translations.
* QUESTION: I'm not clear what the expected 'fix' is for libhivex-perl: binary-or-shlib-defines-rpath? I've read about RPATH
issues (http://wiki.debian.org/RpathIssue) but can't see how it applies in this case. I'm presuming upstream know what they're
doing setting installation targets for the Perl bindings.
RESOLVED: Build-depend on chrpath and add override to debian/rules.
* QUESTION: Perl Policy 4.2 suggests package name convention "...for module Foo::Bar is libfoo-bar-perl." That suggests
the package name here should be "libwin-hivex-perl", which doesn't 'feel' correct. Is "libhivex-perl" acceptable?
* QUESTION: mis-spelling "reencode" in man files by upstream. I would feel extremely pedantic to raise that with the authors on
top of the other queries I've been sending their way. Is this something that can be ignored (maybe with an override) ?
Reply to: