Re: RFS: hivex
A review of your package:
copyright-questions.txt and ubuntu-bug-report-needs-packaging.txt
probably aren't needed in the source package
Why do you override the maintainer-not-full-name lintian complaint?
Please send the patches upstream. If you've already done that, please
document that using DEP-3:
http://dep.debian.net/deps/dep3/
4 of the lines in debian/watch are unnessecary and can be removed.
You are using dpkg-source v3 but still include simple-patchsys.mk from
cdbs, please drop that.
libhivex (but not libhivex-dev) needs to include the ABI number in the
package name. Please read libpkg-guide and its two bug reports:
http://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html
http://bugs.debian.org/libpkg-guide
You added several hardcoded library dependencies, please leave it to
the shlibs mechanism to resolve them at build time.
You Depend on "Perl", I think you meant "perl"?
debian/changelog does not close an ITP bug, only a LaunchPad bug.
debian/copyright misses some information, some files are GPL not LGPL.
You might want to adopt DEP-5 for debian/copyright:
http://dep.debian.net/deps/dep5/
pod2html complaints:
/usr/bin/pod2html: sh/hivexsh.pod: unknown pod directive 'encoding' in
paragraph 1. ignoring.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivex(3)> in paragraph 8.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<virt-cat(1)> in paragraph 8.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<guestfish(1)> in
paragraph 8.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivex(3)/WRITING
TO HIVE FILES> in paragraph 22.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivex(3)> in paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivexget(1)> in
paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<hivexml(1)> in paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<virt-win-reg(1)>
in paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<guestfs(3)> in paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<virt-cat(1)> in
paragraph 73.
/usr/bin/pod2html: sh/hivexsh.pod: cannot resolve L<virt-edit(1)> in
paragraph 73.
dpkg-shlibdeps complaint:
dpkg-shlibdeps: warning: dependency on libncurses.so.5 could be
avoided if "debian/hivex/usr/bin/hivexsh" were not uselessly linked
against it (they use none of its symbols).
dpkg-gencontrol complaints:
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Enhances}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Provides}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Conflicts}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Pre-Depends}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Replaces}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Depends}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Recommends}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Suggests}
dpkg-gencontrol: warning: unused substitution variable ${cdbs:Breaks}
dpkg-gencontrol: warning: unknown substitution variable ${shlibs:Depends}
dpkg-gencontrol: warning: unused substitution variable ${perl:Depends}
lintian complaints:
lintian --info --display-info --display-experimental --pedantic
--show-overrides --checksums --color auto
I: hivex source: duplicate-short-description libhivex libhivex-dev
hivex libhivex-perl libhivex-ocaml
O: hivex source: maintainer-not-full-name TJ
W: libhivex-dev: new-package-should-close-itp-bug
W: libhivex-dev: maintainer-not-full-name TJ
W: libhivex-dev: wrong-section-according-to-package-name libhivex-dev
=> libdevel
W: libhivex: package-name-doesnt-match-sonames libhivex0
W: libhivex: new-package-should-close-itp-bug
W: libhivex: maintainer-not-full-name TJ
W: libhivex: non-dev-pkg-with-shlib-symlink usr/lib/libhivex.so.0.0.0
usr/lib/libhivex.so
I: libhivex: no-symbols-control-file usr/lib/libhivex.so.0.0.0
W: libhivex-ocaml: new-package-should-close-itp-bug
W: libhivex-ocaml: maintainer-not-full-name TJ
P: libhivex-ocaml: ocaml-dev-file-in-nondev-package 3 files in /usr/lib/ocaml
W: hivex: new-package-should-close-itp-bug
W: hivex: maintainer-not-full-name TJ
I: hivex: spelling-error-in-manpage
usr/share/man/man1/hivexregedit.1.gz reencode re-encode
I: hivex: spelling-error-in-manpage
usr/share/man/man1/hivexregedit.1.gz reencode re-encode
E: libhivex-perl: binary-or-shlib-defines-rpath
./usr/lib/perl/5.10.1/auto/Win/Hivex/Hivex.so
/tmp/buildd/hivex-1.2.1/perl/../lib/.libs
W: libhivex-perl: new-package-should-close-itp-bug
W: libhivex-perl: maintainer-not-full-name TJ
W: libhivex-perl: wrong-section-according-to-package-name libhivex-perl => perl
E: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/
: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/Win/
E: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/Win/Hivex.pm
E: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/Win/Hivex/
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/Win/Hivex/Regedit.pm
E: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/auto/
E: libhivex-perl: perl-module-in-core-directory usr/lib/perl/5.10.1/auto/Win/
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/auto/Win/Hivex/
E: libhivex-perl: package-installs-packlist
usr/lib/perl/5.10.1/auto/Win/Hivex/.packlist
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/auto/Win/Hivex/.packlist
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/auto/Win/Hivex/Hivex.bs
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/auto/Win/Hivex/Hivex.so
W: libhivex-perl: package-installs-perllocal-pod
usr/lib/perl/5.10.1/perllocal.pod
E: libhivex-perl: perl-module-in-core-directory
usr/lib/perl/5.10.1/perllocal.pod
I: libhivex-perl: spelling-error-in-manpage
usr/share/man/man3/Win::Hivex::Regedit.3pm.gz reencode re-encode
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: