Re: RFS: gtk2-engines-cleanice: adopted, ITA #553506
Dear Stanislav,
On Mar 28 2010, Stanislav Maslovski wrote:
> Thanks for your detailed review! My comments follow below:
Thank you very much for adopting this package and doing QA work. I did
not even know that it existed.
I just installed it and I have already switched from thinice to this one
(its binary is smaller and I don't need the other engines, since I am a
minimalist person).
> On Sun, Mar 28, 2010 at 06:41:18AM -0300, Rogério Brito wrote:
> > * the source is lintian clean, even with pedantic and experimental. Good.
> > * the md5sum of the provided tarball matches the one from upstream. Good.
> > * the license in the sources is GPL-2, not GPL-2+ as is stated in
> > debian/copyright.
>
> Good eyes! I did not notice it was incorrect and, respectively, did
> not touch that part. I will correct this.
No problems. It is great that you are keeping the licensing straight.
> > * the license in the sources list the old address of the FSF.
>
> Hm, what do you suggest? Provide a patch?
Thinking a little bit further about it, just leave it alone. It would
not be worth to have it corrected just for the few moments when the
package is being built.
OTOH, if upstream is still active, you should communicate it.
[Point to the correct GPL version]
> Agreed.
OK.
[About the descriptions]
> I will look at this.
Great.
> > * perhaps you would want to add the package lxappearance as a
> > Recommends: or Suggests: ?
>
> Hm, I think it should be the other way around.
Yes, yes. You are right. I guess that a bugreport against lxappearance
would be in order so that it depends on some package that provides an
engine.
[AUTHORS file duplicated]
> Yep, my feeling was the same, I just kept it because it was in the
> original package. I will remove it.
As the new maintainer, you have the opportunity of taking all the best
current practices.
> > * some of the files in debian/rules have some trailing whitespace,
> > but this is just nitpicking...
>
> I will look at this also.
That will save us some bytes. :-)
> Many thanks for reviewing!
Thanks for caring about this nice and useful package.
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Reply to: