Re: RFS: sweethome3d
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/02/2010 12:26 AM, Michal Čihař wrote:
> Hi
>
> Dne Mon, 01 Mar 2010 19:01:36 +0100
> Gabriele Giacone <1o5g4r8o@gmail.com> napsal(a):
>
>> On 03/01/2010 08:51 AM, Michal ihaY wrote:
>>> The license seems to be GPL-2+ (at least all file headers I checked say
>>> so). Please fix it in debian/copyright.
>> "you can redistribute it and/or modify it under the terms of the GNU
>> General Public License as published by the Free Software Foundation;
>> either version 2 of the License, or (at your option) any later version."
>> At our option, we can choose GPL-3+, can't we?
>
> What would be the reason for that?
>
> Yes, technically you can, but you are supposed to describe actual
> license in debian/copyright.
Actual before or after our choice? We are redistributing it and we can
choose whether releasing it under version 2 or 3.
"What reason for that?" Why not?
Is GPL-2 better than GPL-3? I'm trying to understand differences between
them.
>
>>> Why is needed 01noMacOSX? All MacOSX code seems to be behind if, so it
>>> should be safe to stay, or am I wrong?
>> Removed some references to MacOSX code. Without those removals, build
>> fails due to classes included in AppleJavaExtension.jar which I didn't
>> replace. I didn't take a deeper look at it.
>
> I would be good idea to document this in patch description. It's always
> good to mention why the patch is needed when it is not obvious.
I'll do it.
>>> Why do you install startup script to usr/share/sweethome3d and create
>>> symlink in usr/bin? I think it should be directly in usr/bin.
>> I already did it for jxplorer: link without .sh extension under /usr/bin
>> that refers to the script under share/<application>
>> /usr/bin/sweethome3d -> ../share/sweethome3d/sweethome3d.sh
>> I like it but we can talk about it.
> Well I feel the symlink and different location is useless, but
I'd like to use <package>.install or dh_install but they don't rename
files. Possibly without "install -d/install" stuff.
And sweethome3d.jar was also feeling alone under /usr/share/sweethome3d ;)
Cheers,
Gabriele
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkuM3K4ACgkQp3cdCbVcnCvXcgCfe5LYw8nhTFQ0/nEGmL674X1q
G8IAniXFJTr0lWaVADTJhk7yLiQXCfJ4
=SwNs
-----END PGP SIGNATURE-----
Reply to: