[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sweethome3d



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Michal,

On 03/01/2010 08:51 AM, Michal Čihař wrote:
> The license seems to be GPL-2+ (at least all file headers I checked say
> so). Please fix it in debian/copyright.
"you can redistribute it and/or modify it under the terms of the GNU
General Public License as published by the Free Software Foundation;
either version 2 of the License, or (at your option) any later version."
At our option, we can choose GPL-3+, can't we?

>> The package is lintian clean and needs freehep-xml and 
>> freehep-graphicsio-svg which are in NEW.
> 
> For upload man would need those packages to test and build, can you
> please provide them somewhere?
http://poisson.phc.unipi.it/~mascellani/debian/freehep-xml_2.1.2+dfsg1-2.dsc
http://poisson.phc.unipi.it/~mascellani/debian/freehep-graphicsio-svg_2.1.1-1.dsc

> Why is needed 01noMacOSX? All MacOSX code seems to be behind if, so it
> should be safe to stay, or am I wrong?
Removed some references to MacOSX code. Without those removals, build
fails due to classes included in AppleJavaExtension.jar which I didn't
replace. I didn't take a deeper look at it.

> Why do you install startup script to usr/share/sweethome3d and create
> symlink in usr/bin? I think it should be directly in usr/bin.
I already did it for jxplorer: link without .sh extension under /usr/bin
that refers to the script under share/<application>

/usr/bin/sweethome3d -> ../share/sweethome3d/sweethome3d.sh

I like it but we can talk about it.

Cheers,
Gabriele



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuMAQAACgkQp3cdCbVcnCs+zACeJatOasy2uwUZq/9B6hq+CZXM
arYAn1tfrpkyYhwqPPLVgsYCy54Jor34
=O1UF
-----END PGP SIGNATURE-----


Reply to: