[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: slimrat



Hi

Dne Wed, 20 Jan 2010 11:01:40 +0000
Paul McEnery <pmcenery@gmail.com> napsal(a):

> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/s/slimrat
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/slimrat/slimrat_1.0-1.dsc

debian/watch seems to be wrong:

uscan warning: In watchfile debian/watch, reading webpage
  http://slimrat.googlecode.com/files/ failed: 404 Not Found

You could use source format 3.0 (quilt) instead of applying patches
manually.

I think you should not override, use debian/clean instead. Also using
debian/links for dh_links could cleanup debian/rules a bit.

You should not install ChangeLog as separate docs, dh_installchangelogs
installs it anyway.

Please do not use own patch headers, use DEP-3 compliant headers
instead.

Lintian does complain:

W: slimrat: manpage-has-bad-whatis-entry usr/share/man/man8/slimrat-gui.8.gz 
W: slimrat: manpage-has-bad-whatis-entry usr/share/man/man8/slimrat.8.gz


-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Attachment: signature.asc
Description: PGP signature


Reply to: