[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: alien-arena (updated package)



On Tue, 19 Jan 2010 19:03:29 +0100 Patrick Matthäi wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Michael Gilbert schrieb:
> > On Mon, 18 Jan 2010 23:27:32 +0100 Patrick Matthäi wrote:
> > 
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Michael Gilbert schrieb:
> >>> On Mon, 18 Jan 2010 22:56:37 +0100 Patrick Matthäi wrote:
> >>>
> >>>> -----BEGIN PGP SIGNED MESSAGE-----
> >>>> Hash: SHA1
> >>>>
> >>>> Michael Gilbert schrieb:
> >>>>> On Mon, 18 Jan 2010 21:34:49 +0100 Patrick Matthäi wrote:
> >>>>>> In general it looks good, but you have missed one important thing, if
> >>>>>> you split up packages: conflicts and replaces.
> >>>>>>
> >>>>>> Now, if users upgrade from 7.0 to 7.33, dpkg would abort, because the
> >>>>>> - -common package include files, which are also present in the
> >>>>>> - -client/-server package.
> >>>>>> So you have to define replaces and conflicts in debian/control.
> >>>>> I have a solution, which I think solves this problem, but I'm not sure
> >>>>> how to test whether to test the it gets resolved correctly with apt.
> >>>>> Any suggestions on how to do that?
> >>>> Without checking your solution now (out of time for today), have a look
> >>>> at the geoip package for example. Have a look at the debian/control and
> >>>> the changelog, why those fields are added.
> >>> I think I have a working solution, which is up on mentors now.
> >>> I'm able to start from all 7.0 packages, then using
> >>>
> >>>   dpkg -i alien-arena_7.33*.deb alien-arena-data_7.33*.deb
> >>>        alien-arena-common_7.33*.deb
> >>>
> >>> does a successful upgrade.  It only required a 'Replaces: alien-arena'
> >>> in alien-arena-common's part of the control file.  Please review.
> >> It should replace alien-arena in version << 7.33. Without any specific
> >> versioning, it would mean, that alien-arena-common replaces alien-arena
> >> at all.
> > 
> >>From reading the devel docs, I interpret 'Replaces' giving another
> > package permission to overwrite files from another package (where
> > normally that would of course be disallowed).  It doesn't actually mean
> > that one package replaces the other package.  
> > 
> >>From that perspective, versioning won't actually do anything since the
> > new alien-arena package doesn't have the files that are now located in
> > alien-arena-common.
> 
> But you won't replace the package at all, just specific versions and not
> the future ones.
> Also you won't see errors, where you packaged the same file in both
> packages.

Ok, that makes sense.  A new version with just that change is now up
on mentors.

Best wishes,
Mike  


Reply to: