[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: easymp3gain



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

* Don't CC me, I am subscribed to -mentors *

Matthias Klumpp schrieb:
> Hi!
> 
>> P: easymp3gain source: source-contains-svn-control-dir lang/.svn
>> - - Just notify and punch upstream, to remove the .svn dirs with his next
>> release tarballs prop.
> Woops! Why wasn't this information shown to mee too? Maybe I should update
> my lintian...

- -IE --pedantic on the *.changes file ;-)

> 
>> W: easymp3gain-gtk: binary-without-manpage usr/bin/easymp3gain
>> - - Yep, just a missing manpage, those are important and also interesent
>> for upstream
> easyMp3Gain is a GUI application, it does not have any command line
> arguments. Is it really necessary to write a manpage, and if it is, who
> should write it? Upstream or me?

Who wants to write it? :)
And yes every binary needs a manpage, if it is missing, it is a bug.

> 
>> I: easymp3gain-gtk: desktop-entry-contains-encoding-key
>> /usr/share/applications/easymp3gain.desktop:2 Encoding
> Submitted to upstream, will be fixed soon.

Fine.

>  
>> I: easymp3gain-gtk: unused-override embedded-zlib
>> - - So and so those are not allowed, but now this isn't the case anymore
>> and just remove the dead override.
> Hmm... This override was necessary last time I compiled it, cause FPC
> embedded the ZLib and there was no flag to turn it off...
> I will remove the override, it does not seem to be necessary for now.

Ok.



- --
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatthaei@debian.org
        patrick@linux-dev.org

Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAktMPZsACgkQ2XA5inpabMfDGACglXn/q3VDjLfbZd3iuLfQRljV
KF8AnjX8WsLPoH7rwgmmvhxAgPk+W2BE
=d58g
-----END PGP SIGNATURE-----


Reply to: