Re: RFS: sciteproj (updated package)
On Sat, 11 Dec 2010 12:02:56 +0100
Niels Thykier <niels@thykier.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 2010-12-08 02:48, Andreas Ronnquist wrote:
> > Dear mentors,
> >
> > I am looking for a sponsor for the new version 0.3.17-1
> > of my package "sciteproj".
> >
> > It builds these binary packages:
> > sciteproj - project manager for the SciTE editor
> >
> > The package appears to be lintian clean.
> >
> > New upstream, with just a small trim to the short description (Removal of the two
> > words "usage with").
> >
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/main/s/sciteproj
> > - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> > - dget http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.3.17-1.dsc
> >
> > I would be glad if someone uploaded this package for me.
> >
> > Kind regards
> > Andreas Rönnquist
>
> Hey
>
> I only had time for a very short review right now; cppcheck reports a
> few leaks in your package. Could you have a look at patching them?
>
>
> Checking src/folder_to_xml.c...
> [src/folder_to_xml.c:168]: (error) Memory leak: shortname
> Checking src/properties_dialog.c...
> [src/properties_dialog.c:174]: (error) Memory leak: size_string
>
> Feel free to ping when you have done that and I will give a more
> thorough review of your package.
>
> Thanks in advance,
> ~Niels
>
Thank you for your review!
I fixed these upstream, and have uploaded a new version to mentors.
> > - dget http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.3.18-1.dsc
best regards
--
Andreas Rönnquist <gusnan@gusnan.se>
Reply to: