Re: RFS: qmagneto
On Mon, Nov 29, 2010 at 5:23 PM, Paul Tagliamonte <paultag@ubuntu.com> wrote:
> I'm not a Debian Developer, so I can't upload. Anyway, here's a review:
>
[snip]
>
> One lintian warning with your dsc:
>
> W: qmagneto source: out-of-date-standards-version 3.8.4 (current is 3.9.1)
>
> postinst should be qmagneto.postinst
> install should be qmagneto.install
> menu should be qmagneto.menu
>
> manpages is empty, you should delete that file.
> docs is empty, you should delete that file
>
> watch is empty, you should fix it.
>
> As much as I love Ubuntu, you should not have Ubuntu versions in the
> Changelog. This looks like a new package, so this must be left over
> from your PPA. FYI, the versions should be appended with ~ppaN. That's
> secondary to the fact that they should not be here :)
>
> You should also be on revision qmagneto_1.3-1, not 4.
>
> Remove all the old uploads from the file, and close an ITP on the
> upload. If you don't have an ITP you should create one.
Sorry, I see you have one, and you're closing it. Just move the
changelog entry to the bottom and get rid of all the other entries.
Also, the close should be the only thing on that line. It's good
you're noting changes, but you don't need to on the first upload. You
should also wrap lines earlier, 80 wide is normal.
>
> Your desktop file has an error:
>
> qmagneto.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
>
> You should fix this as well.
>
> I did not build the application, my netbook has a hard time. I'll
> build it and look at the debs when I get back to my computer.
>
Sidenote before I get to the goodies: It looks like you ship the logos
of some channels in your source. Does this comply with their license?
Can you do that? I'm pretty sure there might be an issue with doing
that. Please double check, and email debian-legal if you are unsure.
That could be enough for the ftp-masters to deny the package.
( but it is impressive how much work you went through for that )
So, I built your package, it built fine. You do, however, have a
litany of issues with the deb:
E: qmagneto: description-starts-with-package-name
I: qmagneto: description-synopsis-might-not-be-phrased-properly
W: qmagneto: description-too-long
E: qmagneto: extended-description-is-empty
P: qmagneto: no-homepage-field
P: qmagneto: copyright-refers-to-symlink-license usr/share/common-licenses/GPL
I: qmagneto: desktop-entry-contains-encoding-key
/usr/share/applications/qmagneto.desktop:2 Encoding
E: qmagneto: menu-item-creates-new-root-section user /usr/share/menu/qmagneto:4
P: qmagneto: no-upstream-changelog
W: qmagneto: syntax-error-in-debian-changelog line 68 "badly formatted
trailer line"
W: qmagneto: syntax-error-in-debian-changelog line 77 "badly formatted
trailer line"
W: qmagneto: debian-changelog-line-too-long line 1
W: qmagneto: binary-without-manpage usr/bin/qmagneto
W: qmagneto: maintainer-script-ignores-errors postinst
E: qmagneto: missing-dependency-on-libc needed by ./usr/bin/qmagneto
I'd fix these up while you're in there working on the debdir. Good luck!
Hope to see the package fixed up!
-Paul
--
All programmers are playwrights, and all computers are lousy actors.
#define sizeof(x) rand()
:wq
Reply to: