[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: php-log (updated package)

Hi Guillaume,

Guillaume Delacour wrote:

> I am looking for a sponsor for the new version 1.12.3-1
> of my package "php-log".

I am not a cdbs or php expert, but this looks pretty good.

Some quick nitpicks:

 - Do you track your packaging with a vcs?  If not, why not? :)
   (Mini-patches are easier to review.)

 - This bumps the required debhelper compat level to 7.  Probably
   worth mentioning in the changelog.

 - I'm assuming the examples are still intended to be installed in
   /usr/share/doc/php-log/examples, but the changelog item

     + Delete nonexistent docs/examples/

   does not make that so clear.

 - Probably it would be simplest to combine the changelog entries
   so there is exactly one entry for each ancestor of the current
   version released in a Debian-derived distribution.

Please feel free to cc me if you have any questions.


Reply to: