[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lowpan-tools



Dmitry Eremin-Solenikov scrisse:

> I am looking for a sponsor for my package "lowpan-tools".

Sorry for taking so much time.
I found some minor issues, which shouldn't be so hard to work our as
you are also upstream author.
First of all, I'm also interested in this package, but I can't maintain
it on my own, as I don't have enough hardware to test it. So, would you
mind co-maintaing it? I'd be useful to put it under alioth collab-maint
in a VCS of your choice (eg. git). Is it fine?

Then, some comments:

* your debian/rules contains some old and commented lines, it could
benefits some cleaning and refactoring (the way you call binary-common
seems a bit strange to me, at a first glance). You may also consider
using helpers from dh7.

* your debian/copyright is a bit incomplete; the repo on github seems
to be vanished, and some files are not GPLv2 (eg. include/ieee802154.h
is LGPLv2.1+ and IMHO coord-config-parse.c may benefit of some
clarification)

* your debian/changelog should mention that this version is the first
officially uploaded, and in theory should refer to an ITP (which I
haven't found, I think you didn't open it).

Your package builds fine, but apart from that I didn't go too much into
technical details, as I'd like to hear from you about co-maintaing and
putting the packaging somewhere.

Cheers, Luca

-- 
 .''`.  ** Debian GNU/Linux **  | Luca Bruno (kaeso)
: :'  :   The Universal O.S.    | lucab (AT) debian.org
`. `'`  			| GPG Key ID: 3BFB9FB3
  `-     http://www.debian.org 	| Debian GNU/Linux Developer

Attachment: pgpsUFSYSn86T.pgp
Description: PGP signature


Reply to: