[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: zathura



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 07/20/2010 10:12 PM, Jakub Wilk wrote:
> * David Prévot <davidp@altern.org>, 2010-07-20, 12:29:
>>> Fixed and uploaded. Anything else?
>>
>> Just tried it, it looks like a nice, simple and quick PDF viewer. Just a
>> remark : upstream README file is pointless for the end user and should
>> me removed from the binary package (removing debian/docs is enough).
> 
> Oh, that's true, this README is totally useless.

I've removed it.

>> The long description might be improved [0] in order to encourage end
>> users to try and install this package. You can ask for advice and
>> review on <debian-l10n-english@lists.debian.org> if you wish.
> 
> To be honest, I've seen worse descriptions. ;) That said, there's no
> harm in asking for review.

Okay, I'll look at it tomorrow

> There's one more thing I just noticed: config.h is created during the
> build, but never removed, so it will end up in
> debian/patches/debian-changes-*.

I've added an override_dh_clean rule in debian/control which removes
config.h.

Kind regards,
- -- 
Sebastian Ramacher
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJMRimiAAoJEGny/FFupxmTXgwQAKpoYSGppcrUwN4Rd4GST4Si
1lzqlvphnL85QQI6KvoDXTUQcfOadZH/b+3S1JLgrzX/z5ToLunXMczPGdCdds28
UN+ERkDB53j2kp5Je9Cs18/2rnS42Yv/XVZRdmbPiFgE4OMImZFQPXliWHdhMw/0
am43BkfbfXBtQTOoyi46CGrP2Co/V3p+oi5NF/8lmPB2HHKwTefrYRpZbqwwzXjH
uA91CcbvuzRFZ9Bm7Gno8h6sHt8SAHK/oNS3gUBu7T3s+JcQt5P5Bv5pov6lBJ21
74KFTA6wMISsYL0gKl8UgLvOYJO+JNbChxBvD6Crup15mU5Wogd1BLxpR2VFKCqv
3GInWHCziLoyf6PywogvGgOahLxy+7wQX1kKlT2MoTW6DiyXYBKcNbBMWb2eJ92P
9JiTl6UFMFSek0HLcq/qtolhxfxbZefsy0skwFZ0PAjdvYrZYlDBlOZ+ycj9Bt4l
jwBT5wQYpXAPwAsXZpFulds//scUBGqft6Ev5IwQUGZsp3XGu+3sbbQ4iQ+WCn6U
rKECKfkm5h9I0a3Fbih+E2MLVBGc3DTwrqNxfIiDWtI/CBG0NRtiyC8iz/HwzAE+
bW1h08xY/GOXmBknvNQgdDq76FtTW+EfbZ7xrxFxDLRNfO8Z7HP2owHIfyr0/5Gh
EussAWGTrZGuX9amOkKW
=vN4D
-----END PGP SIGNATURE-----


Reply to: