Re: RFS: presage

[Paul Wise <pabs@debian.org>]

Wouldn't it be better to merge your patches upstream and release a new version?

I'm not sure if debian/patches/fix-shlib-calls-exit.patch is correct,
shouldn't you replace exit(1) with return 1?

debian/patches/version-shared-library-symbols.patch only seems to
patch generated files.

Is it a good idea to install documentation in latex format as well as
HTML? I would have thought that HTML would be enough for everyone who
wants to read the documentation.

You might also want to push presage into distributions like
OpenEmbedded/SHR, which are used on phones like the OpenMoko
Freerunner.

I don't think every package needs to install THANKS, NEWS.gz,
README.gz, TODO.gz, AUTHORS since some of them will be automatically
installed.

/usr/share/presage/python_binding.txt doesn't look like it needs to be
installed in python-presage, nor libpresage-doc.

resources/presage.png indicates it was generated by inkscape but I
don't see the SVG source code for it.

What is the point of installing /var/lib/presage in libpresage-data?
Only root can modify files there and I doubt root will be using
presage.

Should the symbols file not be more specific about which symbols are present?

I could be wrong, but I don't think the -dev package needs to
explicitly depend on libc6-dev.

libpresage-doc uses /usr/share/doc/presage-doc rather than
/usr/share/doc/libpresage-doc to store the docs, which is slightly
confusing.

The manual pages in the
presage/presage-gprompter/presage-pyprompter/python-presage packages
mention that the full documentation is available in info format, but
no info format documentation is installed.

What do you think about merging presage/presage-gprompter/presage-pyprompter?

/usr/share/presage/getting_started.txt probably belongs in
/usr/share/doc/presage/

Remaining warnings:

pyversions: missing XS-Python-Version in control file, fall back to
debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
dh_clean: dh_clean -k is deprecated; use dh_prep instead
/usr/share/cdbs/1/rules/buildcore.mk:104: WARNING:
DEB_DH_INSTALL_ARGS is a deprecated variable
dpkg-gencontrol: warning: package python-presage: unused substitution
variable ${python:Versions}
dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if
"debian/libpresage1/usr/lib/libpresage.so.1.1.1" were not uselessly
linked against it (they use none of its symbols).

-- 
bye,
pabs

http://wiki.debian.org/PaulWise